From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: "Andreas Färber" <afaerber@suse.de>, "Lee Jones" <lee.jones@linaro.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Mark Brown <broonie@kernel.org>,
Mike Turquette <mturquette@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Kukjin Kim <kgene.kim@samsung.com>,
Doug Anderson <dianders@chromium.org>,
Olof Johansson <olof@lixom.net>,
Sjoerd Simons <sjoerd.simons@collabora.co.uk>,
Daniel Stone <daniels@collabora.com>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Yadwinder Singh Brar <yadi.brar01@gmail.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 12/14] clk: max77802: Add DT binding documentation
Date: Fri, 27 Jun 2014 09:55:51 +0200 [thread overview]
Message-ID: <53AD2387.5090704@collabora.co.uk> (raw)
In-Reply-To: <53AD22D0.9000403@suse.de>
Hello Andres,
Thanks a lot for your feedback.
On 06/27/2014 09:52 AM, Andreas Färber wrote:
> Am 26.06.2014 20:15, schrieb Javier Martinez Canillas:
>> Add Device Tree binding documentation for the clocks
>> outputs in the Maxim 77802 Power Management IC.
>>
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>> ---
>>
>> Changes since v4: None
>>
>> Changes since v3:
>> - Don't use the same clock driver name in clock-names since it's a consumer
>> concept and most probably will be different. Suggested by Doug Anderson.
>>
>> Changes since v2:
>> - Split the DT binding documentation in a separate patch.
>>
>> .../devicetree/bindings/clock/maxim,max77802.txt | 42 ++++++++++++++++++++++
>> 1 file changed, 42 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/clock/maxim,max77802.txt
>>
>> diff --git a/Documentation/devicetree/bindings/clock/maxim,max77802.txt b/Documentation/devicetree/bindings/clock/maxim,max77802.txt
>> new file mode 100644
>> index 0000000..26bc4f7
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/maxim,max77802.txt
>> @@ -0,0 +1,42 @@
>> +Binding for Maxim MAX77802 32k clock generator block
>> +
>> +This is a part of device tree bindings of MAX77802 multi-function device.
>> +More information can be found in bindings/mfd/max77802.txt file.
>> +
>> +The MAX77802 contains two 32.768khz clock outputs that can be controlled
>> +(gated/ungated) over I2C.
>> +
>> +Following properties should be presend in main device node of the MFD chip.
>
> "present"
>
Right, it's a typo. I'll wait for further feedback and will fix both issues you
pointed out in the next version of the series.
> Regards,
> Andreas
>
Best regards,
Javier
next prev parent reply other threads:[~2014-06-27 7:55 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 18:15 [PATCH v5 00/14] Add Maxim 77802 PMIC support Javier Martinez Canillas
2014-06-26 18:15 ` [PATCH v5 01/14] mfd: max77686: Convert to use regmap_irq Javier Martinez Canillas
2014-06-26 18:15 ` [PATCH v5 02/14] mfd: max77686: Allow the max77686 rtc to wakeup the system Javier Martinez Canillas
2014-06-27 9:21 ` Lee Jones
2014-06-27 9:32 ` Javier Martinez Canillas
2014-06-26 18:15 ` [PATCH v5 03/14] clk: max77686: Add DT include for MAX77686 PMIC clock Javier Martinez Canillas
2014-06-27 7:48 ` Andreas Färber
2014-06-27 7:53 ` Javier Martinez Canillas
2014-06-27 8:26 ` Andreas Färber
[not found] ` <53AD2AB7.1090000-l3A5Bk7waGM@public.gmane.org>
2014-06-27 8:54 ` Javier Martinez Canillas
[not found] ` <1403806546-31122-4-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2014-07-01 17:30 ` Mike Turquette
2014-06-26 18:15 ` [PATCH v5 04/14] clk: max77686: Improve Maxim 77686 PMIC clocks binding Javier Martinez Canillas
[not found] ` <1403806546-31122-5-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2014-07-01 17:29 ` Mike Turquette
2014-07-02 10:17 ` Javier Martinez Canillas
2014-07-02 15:21 ` Mike Turquette
2014-06-26 18:15 ` [PATCH v5 05/14] clk: Add generic driver for Maxim PMIC clocks Javier Martinez Canillas
2014-06-30 4:01 ` Yadwinder Singh Brar
2014-06-30 10:58 ` Javier Martinez Canillas
[not found] ` <53B142F1.1050407-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2014-06-30 11:35 ` Russell King - ARM Linux
2014-06-30 16:00 ` Javier Martinez Canillas
2014-07-01 17:26 ` Mike Turquette
2014-07-02 10:13 ` Javier Martinez Canillas
2014-07-02 10:19 ` Krzysztof Kozlowski
2014-06-26 18:15 ` [PATCH v5 06/14] clk: max77686: Convert to the generic max clock driver Javier Martinez Canillas
2014-06-26 18:15 ` [PATCH v5 07/14] mfd: Add driver for Maxim 77802 Power Management IC Javier Martinez Canillas
2014-07-01 15:15 ` Lee Jones
2014-07-01 15:55 ` Javier Martinez Canillas
2014-06-26 18:15 ` [PATCH v5 08/14] mfd: max77802: Add DT binding documentation Javier Martinez Canillas
2014-06-27 8:06 ` Andreas Färber
2014-06-27 8:50 ` Javier Martinez Canillas
2014-06-26 18:15 ` [PATCH v5 09/14] regmap: Add regmap_reg_copy function Javier Martinez Canillas
2014-06-26 18:15 ` [PATCH v5 10/14] regulator: Add driver for Maxim 77802 PMIC regulators Javier Martinez Canillas
2014-06-27 9:26 ` Lee Jones
2014-06-27 9:42 ` Javier Martinez Canillas
2014-06-26 18:15 ` [PATCH v5 11/14] clk: Add driver for Maxim 77802 PMIC clocks Javier Martinez Canillas
2014-06-26 18:15 ` [PATCH v5 12/14] clk: max77802: Add DT binding documentation Javier Martinez Canillas
[not found] ` <1403806546-31122-13-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2014-06-27 7:52 ` Andreas Färber
2014-06-27 7:55 ` Javier Martinez Canillas [this message]
2014-06-26 18:15 ` [PATCH v5 13/14] rtc: Add driver for Maxim 77802 PMIC Real-Time-Clock Javier Martinez Canillas
2014-06-26 18:15 ` [PATCH v5 14/14] ARM: dts: Add max77802 to exynos5420-peach-pit and exynos5800-peach-pi Javier Martinez Canillas
2014-07-02 9:20 ` Tushar Behera
2014-07-02 9:22 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AD2387.5090704@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=a.zummo@towertech.it \
--cc=afaerber@suse.de \
--cc=broonie@kernel.org \
--cc=daniels@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=k.kozlowski@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=olof@lixom.net \
--cc=sameo@linux.intel.com \
--cc=sjoerd.simons@collabora.co.uk \
--cc=tomeu.vizoso@collabora.com \
--cc=yadi.brar01@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).