From: Suman Anna <s-anna@ti.com>
To: Ohad Ben-Cohen <ohad@wizery.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Kumar Gala <galak@codeaurora.org>,
Tony Lindgren <tony@atomide.com>,
Josh Cartwright <joshc@codeaurora.org>,
Bjorn Andersson <bjorn@kryo.se>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-arm <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCHv5 06/15] hwspinlock/omap: enable module before reading SYSSTATUS register
Date: Wed, 2 Jul 2014 14:38:04 -0500 [thread overview]
Message-ID: <53B45F9C.2040209@ti.com> (raw)
In-Reply-To: <CAK=WgbaKPgLLw-4wCSToE86QrREDB0sK95TLx2y17d71eBPFbg@mail.gmail.com>
Hi Ohad,
On 07/01/2014 07:51 AM, Ohad Ben-Cohen wrote:
> Hi Suman,
>
> On Thu, May 1, 2014 at 3:34 AM, Suman Anna <s-anna@ti.com> wrote:
>> The number of hwspinlocks are determined based on the value read
>> from the IP block's SYSSTATUS register. However, the module may
>> not be enabled and clocked, and the read may result in a bus error.
>>
>> This particular issue is seen rather easily on AM33XX, since the
>> module wakeup is software controlled, and it is disabled out of
>> reset. Make sure the module is enabled and clocked before reading
>> the SYSSTATUS register.
>
> This seems like a valid fix that is independent of this patch series.
>
> Feel free to submit it separately if you want, so we can get it merged.
>
OK, I will submit this patch and Patch 7 separately.
regards
Suman
next prev parent reply other threads:[~2014-07-02 19:38 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-01 0:34 [PATCHv5 00/15] hwspinlock/omap dt support Suman Anna
[not found] ` <1398904476-26200-1-git-send-email-s-anna-l0cyMroinI0@public.gmane.org>
2014-05-01 0:34 ` [PATCHv5 01/15] Documentation: dt: add common bindings for hwspinlock Suman Anna
2014-05-02 14:58 ` Rob Herring
2014-05-02 22:46 ` Suman Anna
2014-05-01 0:34 ` [PATCHv5 02/15] Documentation: dt: add the omap hwspinlock bindings document Suman Anna
2014-05-01 0:34 ` [PATCHv5 03/15] hwspinlock/core: maintain a list of registered hwspinlock banks Suman Anna
2014-07-01 12:26 ` Ohad Ben-Cohen
[not found] ` <CAK=WgbakGbTaYz+4K24aT3vyRkDYwPKCm6XrcJvH667NMMfTTA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-02 21:14 ` Suman Anna
2014-07-03 7:00 ` Ohad Ben-Cohen
[not found] ` <CAK=WgbYtJ7TGqvjG3VAPPD5tVXx9-jEJU3iKEStUMxOvD1v=LQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-03 17:28 ` Suman Anna
2014-07-04 5:01 ` Ohad Ben-Cohen
[not found] ` <CAK=WgbaahqdmWRDMKtRhco4y5B-WBFYDHYs2cLM7NL=QhnhK2Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-08 15:22 ` Suman Anna
2014-05-01 0:34 ` [PATCHv5 04/15] hwspinlock/core: add common OF helpers Suman Anna
2014-07-01 12:45 ` Ohad Ben-Cohen
2014-07-02 21:14 ` Suman Anna
2014-07-03 7:15 ` Ohad Ben-Cohen
[not found] ` <CAK=WgbbJ6a17wrsEcvNq6tPiaciQ=E+22QE06t9EA8RFqicNRg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-03 17:35 ` Suman Anna
2014-07-04 4:58 ` Ohad Ben-Cohen
[not found] ` <CAK=WgbbZYwfOyeZuDTX2RXtEdYzsZc++crHZ-ZAqeiWds0BCcg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-08 15:37 ` Suman Anna
2014-05-01 0:34 ` [PATCHv5 05/15] hwspinlock/omap: add support for dt nodes Suman Anna
2014-07-01 12:48 ` Ohad Ben-Cohen
2014-07-02 19:42 ` Suman Anna
2014-07-03 7:25 ` Ohad Ben-Cohen
2014-05-01 0:34 ` [PATCHv5 06/15] hwspinlock/omap: enable module before reading SYSSTATUS register Suman Anna
2014-07-01 12:51 ` Ohad Ben-Cohen
2014-07-02 19:38 ` Suman Anna [this message]
2014-05-01 0:34 ` [PATCHv5 07/15] hwspinlock/omap: enable build for AM33xx, AM43xx & DRA7xx Suman Anna
[not found] ` <1398904476-26200-8-git-send-email-s-anna-l0cyMroinI0@public.gmane.org>
2014-07-01 12:53 ` Ohad Ben-Cohen
2014-05-01 0:34 ` [PATCHv5 RFC 08/15] hwspinlock/core: add support for base id in DT Suman Anna
[not found] ` <1398904476-26200-9-git-send-email-s-anna-l0cyMroinI0@public.gmane.org>
2014-05-05 20:37 ` Rob Herring
[not found] ` <CAL_JsqJW1pqUjQ3DQrppO5n=MmpFOhCyU2zkSzA9s9TpYbq3CA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-05-05 21:37 ` Suman Anna
2014-05-01 0:34 ` [PATCHv5 RFC 09/15] hwspinlock/core: prepare unregister code to support reserved locks Suman Anna
2014-05-01 0:34 ` [PATCHv5 RFC 10/15] hwspinlock/core: prepare core " Suman Anna
2014-05-01 0:34 ` [PATCHv5 RFC 11/15] hwspinlock/core: add support for " Suman Anna
2014-05-01 0:34 ` [PATCHv5 RFC 12/15] hwspinlock/core: add OF helper to parse " Suman Anna
2014-05-05 21:44 ` Suman Anna
[not found] ` <53680639.1080405-l0cyMroinI0@public.gmane.org>
2014-05-05 21:54 ` Josh Cartwright
2014-05-10 1:17 ` Suman Anna
2014-05-01 0:34 ` [PATCHv5 RFC 13/15] hwspinlock/omap: use OF helper to get " Suman Anna
2014-05-01 0:34 ` [PATCHv5 RFC 14/15] hwspinlock/core: return ERR_PTRs on failure in _request_ api Suman Anna
2014-05-01 0:34 ` [PATCHv5 RFC 15/15] hwspinlock/core: change return codes of_hwspin_lock_request_specific Suman Anna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B45F9C.2040209@ti.com \
--to=s-anna@ti.com \
--cc=bjorn@kryo.se \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=joshc@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ohad@wizery.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).