From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH v7 23/24] rtc: Add driver for Maxim 77802 PMIC Real-Time-Clock Date: Mon, 07 Jul 2014 08:57:41 +0200 Message-ID: <53BA44E5.6070604@collabora.co.uk> References: <1404505467-26526-1-git-send-email-javier.martinez@collabora.co.uk> <1404505467-26526-24-git-send-email-javier.martinez@collabora.co.uk> <1404713210.4367.0.camel@AMDC1943> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1404713210.4367.0.camel@AMDC1943> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Krzysztof Kozlowski Cc: Lee Jones , Mark Brown , Mike Turquette , Liam Girdwood , Alessandro Zummo , Kukjin Kim , Doug Anderson , Olof Johansson , Tomeu Vizoso , Yadwinder Singh Brar , Tushar Behera , Andreas Farber , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hello Krzysztof, On 07/07/2014 08:06 AM, Krzysztof Kozlowski wrote: > On pi=C4=85, 2014-07-04 at 22:24 +0200, Javier Martinez Canillas wrot= e: >> The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms. >> This patch adds support for the RTC and is based on a driver >> added by Simon Glass to the Chrome OS kernel 3.8 tree. >>=20 >> Signed-off-by: Javier Martinez Canillas >> --- >>=20 >> Changes since v6: >> - Remove unused code for SMPL and WTSR. Suggested by Krzysztof Kozl= owski. >> - Don't spam the kernel log with unimportant info and just print fo= r debug. >> Suggested by Krzysztof Kozlowski. >> - Use ARRAY_SIZE() instead of constant value. Suggested by Krzyszto= f Kozlowski. >> - Remove duplicated register setup. Suggested by Krzysztof Kozlowsk= i. >> - Don't free/unregister managed allocated resources. >> Suggested by Krzysztof Kozlowski. >> --- >> drivers/rtc/Kconfig | 10 + >> drivers/rtc/Makefile | 1 + >> drivers/rtc/rtc-max77802.c | 508 ++++++++++++++++++++++++++++++++++= +++++++++++ >> 3 files changed, 519 insertions(+) >> create mode 100644 drivers/rtc/rtc-max77802.c >=20 >=20 > Reviewed-by: Krzysztof Kozlowski >=20 Thanks a lot for the review and for all the feedback you gave me on eac= h version of the series. > Best regards, > Krzysztof >=20 >=20 Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html