From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v4] powerpc/powernv: hwmon driver for power, fan rpm, voltage and temperature Date: Mon, 07 Jul 2014 05:59:31 -0700 Message-ID: <53BA99B3.7050605@roeck-us.net> References: <20140704105343.22437.52125.stgit@localhost.localdomain> <53B76220.9090900@roeck-us.net> <1404716172.16156.8.camel@pasglop> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1404716172.16156.8.camel@pasglop> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Benjamin Herrenschmidt Cc: Neelesh Gupta , linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, jdelvare-l3A5Bk7waGM@public.gmane.org, lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org, svaidy-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, sbhat-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On 07/06/2014 11:56 PM, Benjamin Herrenschmidt wrote: > On Fri, 2014-07-04 at 19:25 -0700, Guenter Roeck wrote: >>> +cooling-fan#8-data { >>> + sensor-id = <0x7052107>; >>> + phandle = <0x10000028>; >>> + linux,phandle = <0x10000028>; >>> + compatible = "ibm,opal-sensor-cooling-fan"; >> >> phandle and linux-phandle are neither documented nor used. Either >> document or drop. > > They are core device-tree stuff, as such they are used potentially > anywhere and afaik can be / are generated by DTC but yes, this is > not the place to document them. > Turns out they are documented elsewhere. See Documentation/devicetree/booting-without-of.txt. > Or rather, "phandle" is, "linux,phandle" is an older variant used > for backward compatibility that our firmware still generates but > definitely something we can strip from the doc. > Both are not mentioned in any other bindings, so my take is they should not be mentioned here either. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html