From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH V8 1/6] power: reset: Add generic SYSCON register mapped reset Date: Tue, 08 Jul 2014 20:54:20 -0700 Message-ID: <53BCBCEC.7010306@roeck-us.net> References: <1404872153-3594-1-git-send-email-fkan@apm.com> <1404872153-3594-2-git-send-email-fkan@apm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1404872153-3594-2-git-send-email-fkan@apm.com> Sender: linux-kernel-owner@vger.kernel.org To: Feng Kan , dbaryshkov@gmail.com, catalin.marinas@arm.com, dwmw2@infradead.org, arnd@arndb.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, patches@apm.com List-Id: devicetree@vger.kernel.org On 07/08/2014 07:15 PM, Feng Kan wrote: > Add a generic SYSCON register mapped reset mechanism. > > Signed-off-by: Feng Kan > --- > drivers/power/reset/Kconfig | 6 +++ > drivers/power/reset/Makefile | 1 + > drivers/power/reset/syscon-reboot.c | 91 +++++++++++++++++++++++++++++++++++++ > 3 files changed, 98 insertions(+) > create mode 100644 drivers/power/reset/syscon-reboot.c > > diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig > index bdcf517..5877b38 100644 > --- a/drivers/power/reset/Kconfig > +++ b/drivers/power/reset/Kconfig > @@ -80,3 +80,9 @@ config POWER_RESET_KEYSTONE > help > Reboot support for the KEYSTONE SoCs. > > +config POWER_RESET_SYSCON > + bool "Generic SYSCON regmap reset driver" > + depends on ARM || ARM64 || COMPILE_TEST As written, this driver is really not generic but very arm specific. I don't think COMPILE_TEST is a good idea either, since arm_pm_restart is only defined for the arm architecture. Did you try compiling allmodconfig or allyesconfig for, say, x86_64 with this patch applied ? I think this might benefit from using [1], which would make it really generic. Guenter [1] http://www.spinics.net/lists/kernel/msg1780939.html