devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>,
	"David S. Miller" <davem@davemloft.net>,
	Florian Fainelli <f.fainelli@gmail.com>,
	netdev@vger.kernel.org
Cc: prabhakar.csengg@gmail.com, Sekhar Nori <nsekhar@ti.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	davinci-linux-open-source@linux.davincidsp.com
Subject: Re: [PATCH 1/2] net: davinci_mdio: reuse for keystone2 arch
Date: Wed, 9 Jul 2014 10:20:31 -0400	[thread overview]
Message-ID: <53BD4FAF.8060502@ti.com> (raw)
In-Reply-To: <1404911451-9921-2-git-send-email-grygorii.strashko@ti.com>

On Wednesday 09 July 2014 09:10 AM, Grygorii Strashko wrote:
> The similar MDIO HW blocks is used by keystone 2 SoCs as
> in Davinci SoCs:
> - one in Gigabit Ethernet (GbE) Switch Subsystem
>   See http://www.ti.com/lit/ug/sprugv9d/sprugv9d.pdf
> - one in 10 Gigabit Ethernet Subsystem
>   See http://www.ti.com/lit/ug/spruhj5/spruhj5.pdf
> 
> Hence, reuse Davinci MDIO driver for Keystone 2 and
> enable TI networking for Keystone 2 devices
> 
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
Looks good to me.
Reviewed-by: Santosh Shilimkar <santosh.shilimkar@ti.com>

>  .../devicetree/bindings/net/davinci-mdio.txt       |    8 ++++----
>  drivers/net/ethernet/ti/Kconfig                    |    4 ++--
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/davinci-mdio.txt b/Documentation/devicetree/bindings/net/davinci-mdio.txt
> index 72efaaf..d2e68e7 100644
> --- a/Documentation/devicetree/bindings/net/davinci-mdio.txt
> +++ b/Documentation/devicetree/bindings/net/davinci-mdio.txt
> @@ -1,8 +1,8 @@
> -TI SoC Davinci MDIO Controller Device Tree Bindings
> +TI SoC Davinci/Keystone2 MDIO Controller Device Tree Bindings
>  ---------------------------------------------------
>  
>  Required properties:
> -- compatible		: Should be "ti,davinci_mdio"
> +- compatible		: Should be "ti,davinci_mdio" or "ti,keystone-mdio"
>  - reg			: physical base address and size of the davinci mdio
>  			  registers map
>  - bus_freq		: Mdio Bus frequency
> @@ -19,7 +19,7 @@ file.
>  Examples:
>  
>  	mdio: davinci_mdio@4A101000 {
> -		compatible = "ti,cpsw";
> +		compatible = "ti,davinci_mdio";
>  		reg = <0x4A101000 0x1000>;
>  		bus_freq = <1000000>;
>  	};
> @@ -27,7 +27,7 @@ Examples:
>  (or)
>  
>  	mdio: davinci_mdio@4A101000 {
> -		compatible = "ti,cpsw";
> +		compatible = "ti,davinci_mdio";
>  		ti,hwmods = "davinci_mdio";
>  		bus_freq = <1000000>;
>  	};
> diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
> index 53150c2..1769700 100644
> --- a/drivers/net/ethernet/ti/Kconfig
> +++ b/drivers/net/ethernet/ti/Kconfig
> @@ -5,7 +5,7 @@
>  config NET_VENDOR_TI
>  	bool "Texas Instruments (TI) devices"
>  	default y
> -	depends on PCI || EISA || AR7 || (ARM && (ARCH_DAVINCI || ARCH_OMAP3 || SOC_AM33XX))
> +	depends on PCI || EISA || AR7 || (ARM && (ARCH_DAVINCI || ARCH_OMAP3 || SOC_AM33XX || ARCH_KEYSTONE))
>  	---help---
>  	  If you have a network (Ethernet) card belonging to this class, say Y
>  	  and read the Ethernet-HOWTO, available from
> @@ -32,7 +32,7 @@ config TI_DAVINCI_EMAC
>  
>  config TI_DAVINCI_MDIO
>  	tristate "TI DaVinci MDIO Support"
> -	depends on ARM && ( ARCH_DAVINCI || ARCH_OMAP3 || SOC_AM33XX )
> +	depends on ARM && ( ARCH_DAVINCI || ARCH_OMAP3 || SOC_AM33XX || ARCH_KEYSTONE )
>  	select PHYLIB
>  	---help---
>  	  This driver supports TI's DaVinci MDIO module.
> 

  reply	other threads:[~2014-07-09 14:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-09 13:10 [PATCH 0/2] net: davinci_mdio: reuse for keystone2 arch Grygorii Strashko
2014-07-09 13:10 ` [PATCH 1/2] " Grygorii Strashko
2014-07-09 14:20   ` Santosh Shilimkar [this message]
2014-07-09 23:52   ` David Miller
2014-07-10 12:58     ` Grygorii Strashko
     [not found]       ` <53BE8DF7.9090303-l0cyMroinI0@public.gmane.org>
2014-07-10 19:39         ` David Miller
     [not found]           ` <20140710.123900.1696373067218564684.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2014-07-11 10:24             ` Grygorii Strashko
     [not found]   ` <1404911451-9921-2-git-send-email-grygorii.strashko-l0cyMroinI0@public.gmane.org>
2014-07-11  5:03     ` Mugunthan V N
2014-07-09 13:10 ` [PATCH 2/2] net: davinci_mdio: allow to create phys from dt Grygorii Strashko
     [not found]   ` <1404911451-9921-3-git-send-email-grygorii.strashko-l0cyMroinI0@public.gmane.org>
2014-07-09 14:23     ` Santosh Shilimkar
2014-07-10 13:15       ` Grygorii Strashko
2014-07-11  5:05     ` Mugunthan V N

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53BD4FAF.8060502@ti.com \
    --to=santosh.shilimkar@ti.com \
    --cc=davem@davemloft.net \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=grygorii.strashko@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nsekhar@ti.com \
    --cc=prabhakar.csengg@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).