From: Tuomas Tynkkynen <ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Alan Stern
<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2 2/4] ARM: tegra: Add resets & has-utmi-pad-registers flag to all USB PHYs
Date: Thu, 10 Jul 2014 18:12:48 +0300 [thread overview]
Message-ID: <53BEAD70.5010504@nvidia.com> (raw)
In-Reply-To: <1404436179-10745-3-git-send-email-ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Thierry,
Since Stephen's on a vacation, I'd like to double-check with you that
the DT changes looks good. Greg has applied these to the USB tree today.
Thanks,
Tuomas
On 04/07/14 04:09, Tuomas Tynkkynen wrote:
> Add new properties to all of the Tegra PHYs that are now required
> according to the binding.
>
> In order to stay compatible with old device trees, the USB drivers
> will still function without these reset properties but with the old,
> potentially buggy behaviour.
>
> Signed-off-by: Tuomas Tynkkynen <ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> v2 changes: new patch, didn't exist in v1
> arch/arm/boot/dts/tegra114.dtsi | 5 +++++
> arch/arm/boot/dts/tegra124.dtsi | 7 +++++++
> arch/arm/boot/dts/tegra20.dtsi | 7 +++++++
> arch/arm/boot/dts/tegra30.dtsi | 7 +++++++
> 4 files changed, 26 insertions(+)
>
> diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi
> index 335a1d8..80b8edd 100644
> --- a/arch/arm/boot/dts/tegra114.dtsi
> +++ b/arch/arm/boot/dts/tegra114.dtsi
> @@ -672,6 +672,8 @@
> <&tegra_car TEGRA114_CLK_PLL_U>,
> <&tegra_car TEGRA114_CLK_USBD>;
> clock-names = "reg", "pll_u", "utmi-pads";
> + resets = <&tegra_car 22>, <&tegra_car 22>;
> + reset-names = "usb", "utmi-pads";
> nvidia,hssync-start-delay = <0>;
> nvidia,idle-wait-delay = <17>;
> nvidia,elastic-limit = <16>;
> @@ -682,6 +684,7 @@
> nvidia,hssquelch-level = <2>;
> nvidia,hsdiscon-level = <5>;
> nvidia,xcvr-hsslew = <12>;
> + nvidia,has-utmi-pad-registers;
> status = "disabled";
> };
>
> @@ -705,6 +708,8 @@
> <&tegra_car TEGRA114_CLK_PLL_U>,
> <&tegra_car TEGRA114_CLK_USBD>;
> clock-names = "reg", "pll_u", "utmi-pads";
> + resets = <&tegra_car 59>, <&tegra_car 22>;
> + reset-names = "usb", "utmi-pads";
> nvidia,hssync-start-delay = <0>;
> nvidia,idle-wait-delay = <17>;
> nvidia,elastic-limit = <16>;
> diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi
> index d675186..5b14d79 100644
> --- a/arch/arm/boot/dts/tegra124.dtsi
> +++ b/arch/arm/boot/dts/tegra124.dtsi
> @@ -643,6 +643,8 @@
> <&tegra_car TEGRA124_CLK_PLL_U>,
> <&tegra_car TEGRA124_CLK_USBD>;
> clock-names = "reg", "pll_u", "utmi-pads";
> + resets = <&tegra_car 22>, <&tegra_car 22>;
> + reset-names = "usb", "utmi-pads";
> nvidia,hssync-start-delay = <0>;
> nvidia,idle-wait-delay = <17>;
> nvidia,elastic-limit = <16>;
> @@ -653,6 +655,7 @@
> nvidia,hssquelch-level = <2>;
> nvidia,hsdiscon-level = <5>;
> nvidia,xcvr-hsslew = <12>;
> + nvidia,has-utmi-pad-registers;
> status = "disabled";
> };
>
> @@ -677,6 +680,8 @@
> <&tegra_car TEGRA124_CLK_PLL_U>,
> <&tegra_car TEGRA124_CLK_USBD>;
> clock-names = "reg", "pll_u", "utmi-pads";
> + resets = <&tegra_car 58>, <&tegra_car 22>;
> + reset-names = "usb", "utmi-pads";
> nvidia,hssync-start-delay = <0>;
> nvidia,idle-wait-delay = <17>;
> nvidia,elastic-limit = <16>;
> @@ -711,6 +716,8 @@
> <&tegra_car TEGRA124_CLK_PLL_U>,
> <&tegra_car TEGRA124_CLK_USBD>;
> clock-names = "reg", "pll_u", "utmi-pads";
> + resets = <&tegra_car 59>, <&tegra_car 22>;
> + reset-names = "usb", "utmi-pads";
> nvidia,hssync-start-delay = <0>;
> nvidia,idle-wait-delay = <17>;
> nvidia,elastic-limit = <16>;
> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi
> index 243d84c..1908f69 100644
> --- a/arch/arm/boot/dts/tegra20.dtsi
> +++ b/arch/arm/boot/dts/tegra20.dtsi
> @@ -645,6 +645,8 @@
> <&tegra_car TEGRA20_CLK_CLK_M>,
> <&tegra_car TEGRA20_CLK_USBD>;
> clock-names = "reg", "pll_u", "timer", "utmi-pads";
> + resets = <&tegra_car 22>, <&tegra_car 22>;
> + reset-names = "usb", "utmi-pads";
> nvidia,has-legacy-mode;
> nvidia,hssync-start-delay = <9>;
> nvidia,idle-wait-delay = <17>;
> @@ -653,6 +655,7 @@
> nvidia,xcvr-setup = <9>;
> nvidia,xcvr-lsfslew = <1>;
> nvidia,xcvr-lsrslew = <1>;
> + nvidia,has-utmi-pad-registers;
> status = "disabled";
> };
>
> @@ -676,6 +679,8 @@
> <&tegra_car TEGRA20_CLK_PLL_U>,
> <&tegra_car TEGRA20_CLK_CDEV2>;
> clock-names = "reg", "pll_u", "ulpi-link";
> + resets = <&tegra_car 58>, <&tegra_car 22>;
> + reset-names = "usb", "utmi-pads";
> status = "disabled";
> };
>
> @@ -700,6 +705,8 @@
> <&tegra_car TEGRA20_CLK_CLK_M>,
> <&tegra_car TEGRA20_CLK_USBD>;
> clock-names = "reg", "pll_u", "timer", "utmi-pads";
> + resets = <&tegra_car 59>, <&tegra_car 22>;
> + reset-names = "usb", "utmi-pads";
> nvidia,hssync-start-delay = <9>;
> nvidia,idle-wait-delay = <17>;
> nvidia,elastic-limit = <16>;
> diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi
> index 0b1ede9..6b35c29 100644
> --- a/arch/arm/boot/dts/tegra30.dtsi
> +++ b/arch/arm/boot/dts/tegra30.dtsi
> @@ -790,6 +790,8 @@
> <&tegra_car TEGRA30_CLK_PLL_U>,
> <&tegra_car TEGRA30_CLK_USBD>;
> clock-names = "reg", "pll_u", "utmi-pads";
> + resets = <&tegra_car 22>, <&tegra_car 22>;
> + reset-names = "usb", "utmi-pads";
> nvidia,hssync-start-delay = <9>;
> nvidia,idle-wait-delay = <17>;
> nvidia,elastic-limit = <16>;
> @@ -801,6 +803,7 @@
> nvidia,xcvr-hsslew = <32>;
> nvidia,hssquelch-level = <2>;
> nvidia,hsdiscon-level = <5>;
> + nvidia,has-utmi-pad-registers;
> status = "disabled";
> };
>
> @@ -824,6 +827,8 @@
> <&tegra_car TEGRA30_CLK_PLL_U>,
> <&tegra_car TEGRA30_CLK_USBD>;
> clock-names = "reg", "pll_u", "utmi-pads";
> + resets = <&tegra_car 58>, <&tegra_car 22>;
> + reset-names = "usb", "utmi-pads";
> nvidia,hssync-start-delay = <9>;
> nvidia,idle-wait-delay = <17>;
> nvidia,elastic-limit = <16>;
> @@ -858,6 +863,8 @@
> <&tegra_car TEGRA30_CLK_PLL_U>,
> <&tegra_car TEGRA30_CLK_USBD>;
> clock-names = "reg", "pll_u", "utmi-pads";
> + resets = <&tegra_car 59>, <&tegra_car 22>;
> + reset-names = "usb", "utmi-pads";
> nvidia,hssync-start-delay = <0>;
> nvidia,idle-wait-delay = <17>;
> nvidia,elastic-limit = <16>;
>
--
nvpublic
next prev parent reply other threads:[~2014-07-10 15:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 1:09 [PATCH v2 0/4] Tegra USB probe order issue fix Tuomas Tynkkynen
2014-07-04 1:09 ` [PATCH v2 1/4] USB: tegra: Add resets & has-utmi-pad-registers flag to the PHY binding Tuomas Tynkkynen
2014-07-04 1:09 ` [PATCH v2 2/4] ARM: tegra: Add resets & has-utmi-pad-registers flag to all USB PHYs Tuomas Tynkkynen
[not found] ` <1404436179-10745-3-git-send-email-ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-07-10 15:12 ` Tuomas Tynkkynen [this message]
[not found] ` <53BEAD70.5010504-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-07-14 9:51 ` Thierry Reding
2014-07-04 1:09 ` [PATCH v2 3/4] USB: EHCI: tegra: Fix probe order issue leading to broken USB Tuomas Tynkkynen
2014-07-07 14:16 ` Alan Stern
2014-07-04 1:09 ` [PATCH v2 4/4] USB: PHY: tegra: Call tegra_usb_phy_close only on device removal Tuomas Tynkkynen
[not found] ` <1404436179-10745-5-git-send-email-ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-07-10 13:48 ` Felipe Balbi
[not found] ` <20140710134859.GM15340-HgARHv6XitL9zxVx7UNMDg@public.gmane.org>
2014-07-10 14:02 ` Tuomas Tynkkynen
[not found] ` <1404436179-10745-1-git-send-email-ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-07-04 9:05 ` [PATCH v2 0/4] Tegra USB probe order issue fix Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BEAD70.5010504@nvidia.com \
--to=ttynkkynen-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).