From: Jonathan Cameron <jic23@kernel.org>
To: Naveen Krishna Chatradhi <ch.naveen@samsung.com>,
linux-iio@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, cw00.choi@samsung.com,
gregkh@linuxfoundation.org, naveenkrishna.ch@gmail.com,
lars@metafoo.de, cpgs@samsung.com, grundler@chromium.org,
Kukjin Kim <kgene.kim@samsung.com>
Subject: Re: [PATCH 0/4] iio: exynos-adc: use syscon instead of ioremap
Date: Tue, 15 Jul 2014 19:13:20 +0100 [thread overview]
Message-ID: <53C56F40.1070304@kernel.org> (raw)
In-Reply-To: <1405069589-10388-1-git-send-email-ch.naveen@samsung.com>
On 11/07/14 10:06, Naveen Krishna Chatradhi wrote:
> This patch does the following
> 1. Use the syscon and Regmap API instead of ioremappaing the
> ADC_PHY register from PMU.
> 2. Moves the exynos-adc.txt from bindings/arm/samsung/
> to bindings/iio/adc/.
> 3. Updates the Documentation in exynos-adc.txt with syscon phandle
> for the ADC nodes.
> 4. Updates the Dts files for Exynos3250, Exynos4x12, Exynos5250,
> Exynos5420 with the syscon phandle.
>
> Tested on Exynos5420 based Peach PIT and Exynos5800 based Peach PI
> by verifying sysfs entries provided by HWMON based NTC thermistors.
>
> Tested-By for Exynos3250, Exynos4x12 would be appreciated.
>
This series all looks fine to me. Took me a minute to work out what the point
of the syscon change was (perhaps a little description in the cover letter
would have been nice ;)
Anyhow, with the device tree changes in here we'll have to let it sit for
a while. I'll also definitely want an ack from
Kukjin Kim <kgene.kim@samsung.com> for the device tree changes.
Jonathan
> Naveen Krishna Chatradhi (4):
> iio: exyno-adc: use syscon for PMU register access
> Documentation: dt-bindings: move exynos-adc.txt to more iio/adc/
> Documentation: dt-bindings: update exynos-adc.txt with syscon handle
> ARM: dts: exynos: Add sysreg phandle to ADC node
>
> .../devicetree/bindings/arm/samsung/exynos-adc.txt | 82 ------------------
> .../devicetree/bindings/iio/adc/exynos-adc.txt | 87 ++++++++++++++++++++
> arch/arm/boot/dts/exynos3250.dtsi | 3 +-
> arch/arm/boot/dts/exynos4x12.dtsi | 3 +-
> arch/arm/boot/dts/exynos5250.dtsi | 3 +-
> arch/arm/boot/dts/exynos5420.dtsi | 3 +-
> drivers/iio/adc/exynos_adc.c | 29 +++++--
> 7 files changed, 115 insertions(+), 95 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
> create mode 100644 Documentation/devicetree/bindings/iio/adc/exynos-adc.txt
>
next prev parent reply other threads:[~2014-07-15 18:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 9:06 [PATCH 0/4] iio: exynos-adc: use syscon instead of ioremap Naveen Krishna Chatradhi
2014-07-11 9:06 ` [PATCH 1/4] iio: exyno-adc: use syscon for PMU register access Naveen Krishna Chatradhi
2014-07-11 9:06 ` [PATCH 2/4] Documentation: dt-bindings: move exynos-adc.txt to more iio/adc/ Naveen Krishna Chatradhi
[not found] ` <1405069589-10388-3-git-send-email-ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-07-11 9:17 ` Sachin Kamat
[not found] ` <CAK5sBcFvPo38LtWAhee0xO=KONM5V-UEDzgjCc=uEXtG32NowA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-11 9:22 ` Naveen Krishna Ch
2014-07-11 9:06 ` [PATCH 3/4] Documentation: dt-bindings: update exynos-adc.txt with syscon handle Naveen Krishna Chatradhi
2014-07-11 9:06 ` [PATCH 4/4] ARM: dts: exynos: Add sysreg phandle to ADC node Naveen Krishna Chatradhi
2014-07-15 18:13 ` Jonathan Cameron [this message]
2014-07-15 18:15 ` [PATCH 0/4] iio: exynos-adc: use syscon instead of ioremap Jonathan Cameron
2014-07-17 11:47 ` Naveen Krishna Ch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C56F40.1070304@kernel.org \
--to=jic23@kernel.org \
--cc=ch.naveen@samsung.com \
--cc=cpgs@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=grundler@chromium.org \
--cc=kgene.kim@samsung.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=naveenkrishna.ch@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).