From: Tomasz Figa <t.figa@samsung.com>
To: Abhilash Kesavan <a.kesavan@samsung.com>,
myungjoo.ham@samsung.com, linux-pm@vger.kernel.org,
kgene.kim@samsung.com
Cc: rjw@sisk.pl, kesavan.abhilash@gmail.com, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 3/7] ARM: dts: Add PPMU device tree support for Exynos5250
Date: Wed, 16 Jul 2014 12:56:50 +0200 [thread overview]
Message-ID: <53C65A72.7000406@samsung.com> (raw)
In-Reply-To: <1405449266-26267-1-git-send-email-a.kesavan@samsung.com>
Actually one more comment.
On 15.07.2014 20:34, Abhilash Kesavan wrote:
[snip]
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 834fb5a..5284f00 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -778,4 +778,12 @@
> clocks = <&clock CLK_SSS>;
> clock-names = "secss";
> };
> +
> + ppmu@10C40000 {
> + compatible = "samsung,exynos5250-int-busfreq";
> + reg = <0x10C40000 0x2000 /* PPMU_DDR_C */
> + 0x10C50000 0x2000 /* PPMU_DDR_L */
> + 0x10CB0000 0x2000 /* PPMU_DDR_R */
> + 0x13660000 0x2000>; /* PPMU_RIGHT */
> + };
> };
>
Please separate patches adding the binding from patches modifying device
tree sources. Those are two logically separate changes.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-07-16 10:56 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 17:21 [PATCH RFC v2 0/7] Devfreq support for Exynos5250/5420 Abhilash Kesavan
2014-05-22 17:21 ` [PATCH RFC v2 1/7] clk: exynos5250: add aliases for clocks used by devfreq Abhilash Kesavan
2014-07-15 18:33 ` [PATCH v3 " Abhilash Kesavan
2014-07-16 10:50 ` Tomasz Figa
2014-07-16 18:04 ` Abhilash Kesavan
2014-05-22 17:21 ` [PATCH RFC v2 2/7] clk: exynos5420: Add " Abhilash Kesavan
2014-07-15 18:34 ` [PATCH v3 " Abhilash Kesavan
2014-07-16 10:51 ` Tomasz Figa
2014-05-22 17:21 ` [PATCH RFC v2 4/7] ARM: dts: Add PPMU device tree support for Exynos5420 Abhilash Kesavan
2014-05-22 17:50 ` Sergei Shtylyov
2014-06-16 7:01 ` Abhilash Kesavan
2014-07-15 18:34 ` [PATCH v3 " Abhilash Kesavan
2014-05-22 17:22 ` [PATCH RFC v2 5/7] PM / devfreq: exynos5250: migrate to common-clock Abhilash Kesavan
2014-07-15 18:35 ` [PATCH v3 " Abhilash Kesavan
2014-07-16 11:03 ` Tomasz Figa
2014-07-16 18:00 ` Abhilash Kesavan
2014-05-22 17:22 ` [PATCH RFC v2 6/7] PM / devfreq: exynos: Fix typo in macro Abhilash Kesavan
2014-07-15 18:35 ` [PATCH v3 " Abhilash Kesavan
[not found] ` <1400779322-4410-1-git-send-email-a.kesavan-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-05-22 17:21 ` [PATCH RFC v2 3/7] ARM: dts: Add PPMU device tree support for Exynos5250 Abhilash Kesavan
2014-07-15 18:34 ` [PATCH v3 " Abhilash Kesavan
2014-07-16 10:55 ` Tomasz Figa
2014-07-16 18:00 ` Abhilash Kesavan
2014-07-16 10:56 ` Tomasz Figa [this message]
2014-07-16 18:01 ` Abhilash Kesavan
2014-05-22 17:22 ` [PATCH RFC v2 7/7] PM / devfreq: Add devfreq driver for Exynos5420 Abhilash Kesavan
2014-07-15 18:36 ` [PATCH v3 " Abhilash Kesavan
2014-07-16 11:55 ` Tomasz Figa
2014-07-16 17:59 ` Abhilash Kesavan
2014-07-28 12:01 ` Abhilash Kesavan
2014-05-23 5:08 ` [PATCH RFC v2 0/7] Devfreq support for Exynos5250/5420 Chanwoo Choi
2014-06-16 6:59 ` Abhilash Kesavan
2014-07-15 18:33 ` [PATCH v3 " Abhilash Kesavan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C65A72.7000406@samsung.com \
--to=t.figa@samsung.com \
--cc=a.kesavan@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kesavan.abhilash@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).