devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>,
	Mike Turquette <mturquette@linaro.org>,
	Emilio Lopez <emilio@elopez.com.ar>,
	chris@printf.net, david.lanzendoerfer@o2s.ch,
	ulf.hansson@linaro.org
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mmc@vger.kernel.org
Subject: Re: [PATCH 00/14] clk: sunxi: Improve MMC clocks support
Date: Sat, 19 Jul 2014 12:47:38 +0200	[thread overview]
Message-ID: <53CA4CCA.5040303@redhat.com> (raw)
In-Reply-To: <1405588134-2396-1-git-send-email-maxime.ripard@free-electrons.com>

Hi,

On 07/17/2014 11:08 AM, Maxime Ripard wrote:
> Hi everyone,
>
> Here is an attempt at improving the MMC clock support in the Allwinner
> SoCs.
>
> Until now, the MMC clocks were having a custom phase function that was
> directly setting an obscure value in the right register, because we
> were not really having any idea of what these values were.
>
> Now that we have more informations, we can introduce a common function
> call to get and set the phase of a particular clock, and use this in
> both our provider and our client.
>
> Another issue we had so far on the A13 was that, out of reset, the
> PLL6 driving the MMC was running too high to be working. We can solve
> that by adding two new properties in the DT to setup the rate
> constraints we might have on a clock.

Looks good to me, thanks for working on this.

Question have you dumped the raw mmc0 clk reg before and after this
patch set to verify that the end result is the same ?

Regards,

Hans

  parent reply	other threads:[~2014-07-19 10:47 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-17  9:08 [PATCH 00/14] clk: sunxi: Improve MMC clocks support Maxime Ripard
2014-07-17  9:08 ` [PATCH 01/14] clk: Introduce new frequency boundaries properties Maxime Ripard
2014-07-17  9:08 ` [PATCH 02/14] clk: sunxi: factors: Implement clock min and max frequencies Maxime Ripard
2014-07-17 16:09   ` Emilio López
2014-07-17  9:08 ` [PATCH 04/14] clk: introduce clk_set_phase function & callback Maxime Ripard
2014-07-17  9:08 ` [PATCH 05/14] clk: Add a function to retrieve phase Maxime Ripard
2014-07-17  9:08 ` [PATCH 08/14] ARM: sunxi: dt: Switch to the new mbus compatible Maxime Ripard
2014-07-17  9:08 ` [PATCH 09/14] clk: sunxi: Move mod0 clock to a file of its own Maxime Ripard
2014-07-17  9:08 ` [PATCH 12/14] clk: sunxi: mod0: Introduce MMC proper phase handling Maxime Ripard
2014-07-17  9:08 ` [PATCH 13/14] mmc: sunxi: Convert MMC driver to the standard clock phase API Maxime Ripard
2014-08-13  8:44   ` Ulf Hansson
     [not found] ` <1405588134-2396-1-git-send-email-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-07-17  9:08   ` [PATCH 03/14] ARM: sunxi: sun5i: Enforce max frequency on PLL6 Maxime Ripard
2014-07-17 16:19     ` Emilio López
2014-07-17  9:08   ` [PATCH 06/14] clk: sunxi: factors: Invert the probing logic Maxime Ripard
2014-07-17  9:08   ` [PATCH 07/14] clk: sunxi: Introduce mbus compatible Maxime Ripard
2014-08-25 14:17     ` Chen-Yu Tsai
2014-08-25 15:18       ` Maxime Ripard
2014-07-17  9:08   ` [PATCH 10/14] clk: sunxi: Move mbus to mod0 file Maxime Ripard
2014-07-17  9:08   ` [PATCH 11/14] ARM: sunxi: dt: Add sample and output mmc clocks Maxime Ripard
2014-07-17  9:08   ` [PATCH 14/14] clk: sunxi: Remove custom phase function Maxime Ripard
2014-07-19 10:47 ` Hans de Goede [this message]
2014-07-24 11:20   ` [PATCH 00/14] clk: sunxi: Improve MMC clocks support Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53CA4CCA.5040303@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=chris@printf.net \
    --cc=david.lanzendoerfer@o2s.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=emilio@elopez.com.ar \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=maxime.ripard@free-electrons.com \
    --cc=mturquette@linaro.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).