From mboxrd@z Thu Jan 1 00:00:00 1970 From: caesar Subject: Re: [PATCH v2 1/2] pwm: add this patch to introduce for rk-pwm and vop-pwm Date: Mon, 21 Jul 2014 18:39:07 +0800 Message-ID: <53CCEDCB.5010500@rock-chips.com> References: <1405774529-26027-1-git-send-email-caesar.wang@rock-chips.com> <1405774529-26027-2-git-send-email-caesar.wang@rock-chips.com> <20140721085716.GH8843@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20140721085716.GH8843@ulmo> Sender: linux-pwm-owner@vger.kernel.org To: Thierry Reding Cc: heiko@sntech.de, b.galvani@gmail.com, cf@rock-chips.com, huangtao@rock-chips.com, addy.ke@rock-chips.com, xjq@rock-chips.com, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi Thierry, =E4=BA=8E 2014=E5=B9=B407=E6=9C=8821=E6=97=A5 16:57, Thierry Reding =E5= =86=99=E9=81=93: > On Sat, Jul 19, 2014 at 08:55:28PM +0800, Caesar Wang wrote: >> Signed-off-by: Caesar Wang >> --- >> Documentation/devicetree/bindings/pwm/pwm-rockchip.txt | 13 ++++++= ++----- >> 1 file changed, 8 insertions(+), 5 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/pwm/pwm-rockchip.txt = b/Documentation/devicetree/bindings/pwm/pwm-rockchip.txt >> index 3182126..bb6e7f1 100644 >> --- a/Documentation/devicetree/bindings/pwm/pwm-rockchip.txt >> +++ b/Documentation/devicetree/bindings/pwm/pwm-rockchip.txt >> @@ -1,11 +1,14 @@ >> Rockchip PWM controller >> =20 >> Required properties: >> - - compatible: should be "rockchip,rk2928-pwm" >> - - reg: physical base address and length of the controller's regist= ers >> - - clocks: phandle and clock specifier of the PWM reference clock >> - - #pwm-cells: should be 2. See pwm.txt in this directory for a >> - description of the cell format. > Can you please stick to the original format rather than removing the > space in the first column? It makes it difficult to see what's being > changed by this patch. ok=EF=BC=8C >> +- compatible: should be "rockchip,-pwm"should be one of follo= wing: > I think it should be either 'should be "rockchip,-pwm"' or 'sho= uld > be one of the following', not both. Seems reasonable. > >> + "rockchip,rk2928-pwm" - support the old version PWM for RK29xx,= RK3066,RK3188 SoCs. >> + "rockchip,rk3288-pwm" - support the new version PWM for RK3036,= RK3288 SoCs. >> + "rockchip,vop-pwm" - support rockchip integrated VOP-PWM for RK= 32 SoCs. > "old version PWM" and "new version PWM" can be dropped. Maybe: > > "rockchip,rk2928-pwm": found on RK29xx, RK3066 and RK3188 SoCs > "rockchip,rk3288-pwm": found on RK3036 and RK3288 SoCs > "rockchip,vop-pwm": found integrated in VOP on RK32xx SoCs > > ? Could you explain a little what this VOP is? Also since the above s= ays > that "rockchip,rk3288-pwm" is supported on RK3036, the compatible val= ue > should really be "rockchip,rk3036-pwm" since we usually list the chip > that an IP block was first used in (I'm assuming here that RK3036 is > older than RK3288). the SoC rk3036 is newer than rk3288. Maybe I will remove the rk3036. It's the genenation Soc. VOP is the display interface from memory frame buffer to display device= =20 (LCD panel, LVDS,MIPI, eDP, HDMI and TV set). VOP is connected to an AHB bus through an AHB slave and AXI bus through= =20 an AXI master. The register setting is configured through the AHB slave interface and=20 the display frame data is read through the AXI master interface. =46urthermore, there is adata path between IEP and VOP, which can provi= de=20 frame data from IEP to VOP. If you are interested in it,I will sent the vop doc for you and explain= it. >> +- reg: physical base address and length of the controller's registe= rs. >> +- clocks: phandle and clock specifier of the PWM reference clock. >> +- #pwm-cells: should be 2. See pwm.txt in this directory for a >> + description of the cell format. > These are all unchanged (except for the first column's space being > removed and the full-stops for reg and clocks properties). Please kee= p > with the original formatting so that it becomes obvious what the patc= h > changes. > > Thierry I will fix this and the other issuses in v3,thanks. Caesar