From: Varka Bhadram <varkabhadram@gmail.com>
To: YoungJun Cho <yj44.cho@samsung.com>,
airlied@linux.ie, dri-devel@lists.freedesktop.org
Cc: devicetree@vger.kernel.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux-samsung-soc@vger.kernel.org, thierry.reding@gmail.com,
kyungmin.park@samsung.com, inki.dae@samsung.com,
kgene.kim@samsung.com, jy0922.shim@samsung.com,
sw0312.kim@samsung.com, a.hajda@samsung.com
Subject: Re: [PATCH v6 05/14] drm/exynos: dsi: add TE interrupt handler to support LCD I80 interface
Date: Tue, 22 Jul 2014 16:27:55 +0530 [thread overview]
Message-ID: <53CE43B3.2080203@gmail.com> (raw)
In-Reply-To: <1406026184-29185-1-git-send-email-yj44.cho@samsung.com>
On 07/22/2014 04:19 PM, YoungJun Cho wrote:
(...)
> + ret = gpio_request_one(dsi->te_gpio, GPIOF_IN, "te_gpio");
devm_* APIs..?
> + if (ret) {
> + dev_err(dsi->dev, "gpio request failed with %d\n", ret);
> + goto out;
> + }
> +
> + /*
> + * This TE GPIO IRQ should not be set to IRQ_NOAUTOEN, because panel
> + * calls drm_panel_init() first then calls mipi_dsi_attach() in probe().
> + * It means that te_gpio is invalid when exynos_dsi_enable_irq() is
> + * called by drm_panel_init() before panel is attached.
> + */
> + ret = request_threaded_irq(gpio_to_irq(dsi->te_gpio),
> + exynos_dsi_te_irq_handler, NULL,
> + IRQF_TRIGGER_RISING, "TE", dsi);
why don't we use devm_request_threaded_irq()..?
--
Regards,
Varka Bhadram.
next prev parent reply other threads:[~2014-07-22 10:57 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 9:01 [PATCH v6 00/14] drm/exynos: support LCD I80 interface display YoungJun Cho
2014-07-17 9:01 ` [PATCH v6 01/14] drm/exynos: dsi: move the EoT packets configuration point YoungJun Cho
2014-07-17 9:01 ` [PATCH v6 02/14] drm/exynos: use wait_event_timeout() for safety usage YoungJun Cho
2014-07-17 9:01 ` [PATCH v6 03/14] ARM: dts: samsung-fimd: add LCD I80 interface specific properties YoungJun Cho
2014-07-17 9:01 ` [PATCH v6 04/14] drm/exynos: add TE handler to support LCD I80 interface YoungJun Cho
2014-07-17 9:01 ` [PATCH v6 05/14] drm/exynos: dsi: add TE interrupt " YoungJun Cho
2014-07-21 14:01 ` Andrzej Hajda
2014-07-22 1:23 ` Inki Dae
2014-07-22 2:15 ` YoungJun Cho
2014-07-22 10:12 ` Andrzej Hajda
2014-07-22 10:26 ` YoungJun Cho
2014-07-22 10:49 ` YoungJun Cho
2014-07-22 10:57 ` Varka Bhadram [this message]
2014-07-22 11:10 ` YoungJun Cho
2014-07-22 11:14 ` Varka Bhadram
2014-07-22 11:53 ` YoungJun Cho
2014-07-22 12:01 ` Varka Bhadram
2014-07-17 9:01 ` [PATCH v6 06/14] drm/exynos: fimd: " YoungJun Cho
2014-07-17 9:01 ` [PATCH v6 07/14] ARM: dts: exynos_dsim: add exynos5410 compatible to DT bindings YoungJun Cho
2014-07-17 9:01 ` [PATCH v6 08/14] drm/exynos: dsi: add driver data to support Exynos5410/5420/5440 SoCs YoungJun Cho
2014-07-17 9:01 ` [PATCH v6 09/14] ARM: dts: s6e3fa0: add DT bindings YoungJun Cho
2014-07-17 10:38 ` Thierry Reding
2014-07-18 2:00 ` YoungJun Cho
2014-07-17 9:01 ` [PATCH v6 10/14] drm/panel: add S6E3FA0 driver YoungJun Cho
2014-07-17 10:36 ` Thierry Reding
2014-07-18 1:49 ` YoungJun Cho
2014-07-21 8:56 ` Andrzej Hajda
2014-07-21 9:19 ` Thierry Reding
2014-07-21 11:18 ` Andrzej Hajda
2014-07-22 3:41 ` YoungJun Cho
2014-07-22 7:49 ` Thierry Reding
2014-07-22 10:20 ` YoungJun Cho
2014-07-30 13:44 ` Tomi Valkeinen
2014-07-30 14:36 ` Thierry Reding
2014-07-30 13:40 ` Tomi Valkeinen
2014-07-21 9:35 ` Thierry Reding
2014-07-22 3:56 ` YoungJun Cho
2014-07-29 13:08 ` YoungJun Cho
2014-07-17 9:01 ` [PATCH v6 11/14] ARM: dts: exynos4: add system register property YoungJun Cho
2014-07-17 9:01 ` [PATCH v6 12/14] ARM: dts: exynos5: " YoungJun Cho
2014-07-17 9:01 ` [PATCH v6 13/14] ARM: dts: exynos5420: add mipi-phy node YoungJun Cho
2014-07-17 9:01 ` [PATCH v6 14/14] ARM: dts: exynos5420: add dsi node YoungJun Cho
2014-07-22 13:48 ` [PATCH v6 00/14] drm/exynos: support LCD I80 interface display Inki Dae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CE43B3.2080203@gmail.com \
--to=varkabhadram@gmail.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=inki.dae@samsung.com \
--cc=jy0922.shim@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sw0312.kim@samsung.com \
--cc=thierry.reding@gmail.com \
--cc=yj44.cho@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).