From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH 2/2] ARM: mvebu: Added dts defintion for Lenovo Iomega ix4-300d NAS Date: Thu, 24 Jul 2014 14:21:03 +0200 Message-ID: <53D0FA2F.6050209@free-electrons.com> References: <1406154923-13612-1-git-send-email-yahoo@perenite.com> <1406154923-13612-2-git-send-email-yahoo@perenite.com> <20140723224236.GC28485@lunn.ch> <94F87063-D717-435B-B7C5-EDAC9B26742C@perenite.com> <20140723225841.GD28485@lunn.ch> <10A7C530-7CD2-4ED0-889A-7FAC1922320F@perenite.com> <20140723231535.GK23220@titan.lakedaemon.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20140723231535.GK23220@titan.lakedaemon.net> Sender: linux-kernel-owner@vger.kernel.org To: Jason Cooper , Benoit Masson Cc: Andrew Lunn , Benoit Masson , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Russell King , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org On 24/07/2014 01:15, Jason Cooper wrote: > On Thu, Jul 24, 2014 at 01:11:12AM +0200, Benoit Masson wrote: >> Le 24 juil. 2014 =E0 00:58, Andrew Lunn a =E9crit : >> >>>> For the marvell,mv78230-a0-i2c unfortunately i've spend 3 hours >>>> trying to understand this but it only works with this on the >>>> ix4-300d :(. There was multiple patch around this and maybe one >>>> broke the auto-detect part of this, I've tried compiling with some >>>> 3.10 or lower kernel but no luck here I still have to put this a0 >>>> option. >>> >>> Lets first confirm you have an a0 SoC. >>> >>> At boot time, it should print: >>> >>> pr_info("MVEBU SoC ID=3D0x%X, Rev=3D0x%X\n", soc_dev_id, soc_rev); >>> >>> What revision do you have? >>> >>> If the auto detect code really is broken, Gregory will likely take = a >>> look. >> >> I sure do, >> >> confirmed by u-boot output below: >> >> U-Boot 2009.08 (Mar 04 2013 - 11:13:04) Marvell version: 2.3.2 PQ >> U-Boot Addressing: >> Code:..00600000:006BFFF0 >> BSS:..00708EC0 >> Stack:..0x5fff70 >> PageTable:.0x8e0000 >> Heap address:.0x900000:0xe00000 >> Board: DB-78230-BP rev 2.0 Wistron >> SoC: MV78230 A0 >> >> From kernel I get: >> >> mvebu-soc-id: MVEBU SoC ID=3D0x7823, Rev=3D0x1 >=20 > Well, isn't that a peach? :) Gregory? A peach?? For me it is either a fruit or a princess, so I am puzzled! Well about the issue, we patch the device tree for the i2c quirk only f= or the openblock AX3. If I remember well it was because the device tree wa= s already written for this board before we found there was an issue with the A0 v= ersion of the CPU. The rule was that for new boards then they have to set the marvell= ,mv78230-a0-i2c compatible string. I also didn't expect that we found "new" product usi= ng the A0 version. We have 3 options now: - remove the check on the openblock AX3 board and always try to apply t= he quirck for A0 version - add a check for this new board in the mvebu_dt_init function - let the compatible string marvell,mv78230-a0-i2c in this dts I would prefer the option 1 but I fear that Arnd would prefer the 2 oth= er options. Gregory >=20 > thx, >=20 > Jason. >=20 --=20 Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com