From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Subject: Re: [PATCH v2 08/11] ARM: dts: zynq: Add VDMA to Parallella Date: Fri, 25 Jul 2014 11:47:05 +0200 Message-ID: <53D22799.8050903@suse.de> References: <1406242820-20140-1-git-send-email-afaerber@suse.de> <1406242820-20140-9-git-send-email-afaerber@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?UTF-8?B?U8O2cmVuIEJyaW5rbWFubg==?= Cc: Michal Simek , Andreas Olofsson , Matteo Vit , Sean Rickerd , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King List-Id: devicetree@vger.kernel.org Hi S=C3=B6ren, Am 25.07.2014 01:22, schrieb S=C3=B6ren Brinkmann: > On Fri, 2014-07-25 at 01:00AM +0200, Andreas F=C3=A4rber wrote: >> Signed-off-by: Andreas F=C3=A4rber >> --- >> v2: New >> =20 >> arch/arm/boot/dts/zynq-parallella.dts | 25 ++++++++++++++++++++++++= + >> 1 file changed, 25 insertions(+) >> >> diff --git a/arch/arm/boot/dts/zynq-parallella.dts b/arch/arm/boot/d= ts/zynq-parallella.dts >> index e60a0a9..8beaacc 100644 >> --- a/arch/arm/boot/dts/zynq-parallella.dts >> +++ b/arch/arm/boot/dts/zynq-parallella.dts >> @@ -32,6 +32,31 @@ >> bootargs =3D "console=3DttyPS0,115200 earlyprintk root=3D/dev/mmc= blk0p2 rootfstype=3Dext4 rw rootwait"; >> linux,stdout-path =3D "/amba/serial@e0001000"; >> }; >> + >> + fpga { > Do you really want FPGA components in this DT? > If somebody tries booting with this DT without programming with a > corresponding bitstream, the whole system might hang. > Just something to consider. Well, that's related to a question that remained unanswered on v1: whether we may need to turn this into a .dtsi to cope with variations. The Parallella has an on-board =C2=B5HDMI connector, and two bitstreams= are delivered - one for HDMI and one for headless usage. In my testing I am using the original HDMI bitstream but serial console for lack of upstream HDMI drivers. Do you think we need to provide zynq-parallella-hdmi.dts and zynq-parallella-headless.dts? (It gets worse if at some point we need to handle variations of the on-board Epiphany chip plus the bitstreams - at least the Z7010 vs. Z7020 doesn'= t affect DT AFAICT.) Since, as noted in the cover letter, these FPGA patches are not yet fully testable, I wouldn't mind deferring them, but wanted to get them out for review early. http://www.parallella.org/2014/07/14/new-parallella-product-offerings/ indicates there will be a new variation in gen2 without USB/HDMI. Would it be valid to #include a .dts (rather than .dtsi) to override status and keep number of Parallella files low? Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3= =BCrnberg -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html