From: "Andreas Färber" <afaerber@suse.de>
To: Doug Anderson <dianders@chromium.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
"OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Vincent Palatin <vpalatin@chromium.org>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
LKML <linux-kernel@vger.kernel.org>,
Stephan van Schaik <stephan@synkhronix.com>,
Russell King <linux@arm.linux.org.uk>,
Rob Herring <robh+dt@kernel.org>, Ben Dooks <ben-linux@fluff.org>,
Kumar Gala <galak@codeaurora.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
"ARM/SAMSUNG ARM A..." <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/4] ARM: dts: exynos5250: max77686 is Snow only
Date: Fri, 25 Jul 2014 17:30:12 +0200 [thread overview]
Message-ID: <53D27804.40601@suse.de> (raw)
In-Reply-To: <CAD=FV=VeBP=1CiKesp738anZzSJNZCGkg68RBUUCyJ5U6_Y75w@mail.gmail.com>
Hi Doug,
Am 25.07.2014 17:13, schrieb Doug Anderson:
> On Fri, Jul 25, 2014 at 8:08 AM, Doug Anderson <dianders@chromium.org> wrote:
>> On Thu, Jul 24, 2014 at 10:28 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
>>> Andreas Färber wrote:
>>>>
>>>> Move it from exynos5250-cros-common.dtsi to exynos5250-snow.dts.
>>>> Spring does not need it, it uses an s5m8767 instead.
>>>>
>>>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>>>> ---
>>>
>>> Doug, can you have a look this series for exynos5250-chromebook?
>>> I'm not sure exynos5250-cros-common is still useful for exynos5250-spring...
>>
>> Right. The current suggestion is to rework to just duplicate things
>> and don't use exynos5250-cros-common.
>
> Oh, it actually looks like your patch series ends up there, but the
> first patch confused me.
NP, guess you just started reading in the middle. ;)
> Why move just the maxim PMIC first?
Review of the movements surely is easier this way, and it did not yet
seem a done deal that we would drop -cros-common. The merge patch nicely
shows which common parts need to be copied into spring.
> Move
> everything at once and be done with the common file, then do
> cleanup...
If everyone agrees that we want to proceed that way, we can easily
squash patches 1+2. Separating is always harder.
Cheers,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2014-07-25 15:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1405704009-8430-1-git-send-email-afaerber@suse.de>
2014-07-18 17:20 ` [PATCH v2 1/4] ARM: dts: exynos5250: max77686 is Snow only Andreas Färber
2014-07-25 5:28 ` Kukjin Kim
2014-07-25 15:08 ` Doug Anderson
2014-07-25 15:13 ` Doug Anderson
2014-07-25 15:30 ` Andreas Färber [this message]
2014-07-25 16:02 ` Doug Anderson
2014-07-29 16:15 ` Doug Anderson
2014-07-18 17:20 ` [PATCH v2 2/4] ARM: dts: exynos5250: cypress,cyapa trackpad " Andreas Färber
2014-07-29 16:16 ` Doug Anderson
2014-07-29 23:06 ` Kukjin Kim
2014-07-30 0:21 ` Andreas Färber
2014-07-18 17:20 ` [PATCH v2 3/4] ARM: dts: exynos5250: Fold common ChromeOS parts into Snow Andreas Färber
2014-07-25 16:02 ` Doug Anderson
2014-07-29 12:45 ` Andreas Färber
2014-07-29 15:11 ` Doug Anderson
2014-07-25 16:35 ` Javier Martinez Canillas
2014-07-25 16:43 ` Doug Anderson
2014-07-25 17:02 ` Javier Martinez Canillas
2014-07-29 13:00 ` Andreas Färber
2014-07-29 14:39 ` Javier Martinez Canillas
2014-07-29 15:27 ` Doug Anderson
2014-07-18 17:20 ` [PATCH v2 4/4] ARM: dts: exynos5250: Add Spring device tree Andreas Färber
2014-07-25 16:02 ` Doug Anderson
[not found] ` <CAD=FV=Xu9b6433pV=bqi3jZZR03G6nyi2iNgbSXwAcRY4Y=4yA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-30 13:06 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D27804.40601@suse.de \
--to=afaerber@suse.de \
--cc=ben-linux@fluff.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=javier.martinez@collabora.co.uk \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=stephan@synkhronix.com \
--cc=vpalatin@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).