From: Tomasz Figa <tomasz.figa@gmail.com>
To: "Andreas Färber" <afaerber@suse.de>, linux-samsung-soc@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Stephan van Schaik <stephan@synkhronix.com>,
Vincent Palatin <vpalatin@chromium.org>,
Doug Anderson <dianders@chromium.org>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Tomasz Figa <t.figa@samsung.com>, Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 07/10] ARM: dts: Clean up exynos5250-arndale
Date: Fri, 01 Aug 2014 23:03:52 +0200 [thread overview]
Message-ID: <53DC00B8.3050008@gmail.com> (raw)
In-Reply-To: <1406868897-26874-8-git-send-email-afaerber@suse.de>
Just wanted to report one issue unrelated to your changes I spotted
while reviewing this patch. See below.
On 01.08.2014 06:54, Andreas Färber wrote:
> Use the new style of referencing inherited nodes, use symbolic names,
> tidy indentation and reorder includes.
>
> Goal is the alignment of all exynos5250 based device trees for comparison.
[snip]
> - fimd: fimd@14400000 {
> - status = "okay";
> - display-timings {
> - native-mode = <&timing0>;
> - timing0: timing@0 {
> - /* 2560x1600 DP panel */
> - clock-frequency = <50000>;
This apparently makes little sense as I doubt anybody would be willing
to run a DP panel with refresh rate of 0,012 Hz...
Anyway, your patch just moves it, so this is just an unrelated report.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-08-01 21:03 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 4:54 [PATCH v5 00/10] ARM: dts: exynos: Prepare Spring Andreas Färber
2014-08-01 4:54 ` [PATCH v5 01/10] ARM: dts: Fix MMC pinctrl for exynos5250-snow Andreas Färber
2014-08-01 16:26 ` Doug Anderson
2014-08-18 18:37 ` Kukjin Kim
2014-08-18 18:48 ` Tomasz Figa
2014-08-18 20:03 ` Kukjin Kim
[not found] ` <53F25C25.4070602-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-08-18 20:13 ` Andreas Färber
2014-08-01 4:54 ` [PATCH v5 02/10] ARM: dts: Fold exynos5250-cros-common into exynos5250-snow Andreas Färber
2014-08-01 16:45 ` Doug Anderson
[not found] ` <CAD=FV=USKuOxiFo=VgEB6aAQ=LdLv-7+jXQNh4VCMBQwasygxg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-08-18 20:03 ` Kukjin Kim
2014-08-01 4:54 ` [PATCH v5 03/10] ARM: dts: Clean up exynos5250-snow Andreas Färber
2014-08-01 20:24 ` Doug Anderson
2014-08-01 20:44 ` Andreas Färber
2014-08-01 4:54 ` [PATCH v5 04/10] ARM: dts: Fill in bootargs for exynos5250-snow Andreas Färber
2014-08-01 20:28 ` Doug Anderson
2014-08-01 21:10 ` Andreas Färber
2014-08-02 5:01 ` Doug Anderson
2014-08-01 4:54 ` [PATCH v5 05/10] ARM: dts: Move dp_hpd from exynos5250 into smdk5250 and snow Andreas Färber
2014-08-01 20:33 ` Doug Anderson
2014-08-01 20:54 ` Andreas Färber
2014-08-01 20:57 ` Tomasz Figa
2014-08-05 12:16 ` Jingoo Han
2014-08-10 9:15 ` Andreas Färber
2014-08-11 10:24 ` Jingoo Han
2014-08-01 4:54 ` [PATCH v5 06/10] ARM: dts: Clean up exynos5250-smdk5250 Andreas Färber
2014-08-01 11:42 ` Andreas Färber
[not found] ` <1406868897-26874-7-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org>
2014-08-01 20:37 ` Doug Anderson
2014-08-01 4:54 ` [PATCH v5 07/10] ARM: dts: Clean up exynos5250-arndale Andreas Färber
2014-08-01 21:03 ` Tomasz Figa [this message]
2014-08-01 4:54 ` [PATCH v5 08/10] ARM: dts: Fix apparent GPIO typo in exynos5250-arndale Andreas Färber
2014-08-01 4:54 ` [PATCH v5 09/10] ARM: dts: Simplify USB3503 on exynos5250-arndale Andreas Färber
2014-08-01 4:54 ` [PATCH v5 10/10] ARM: dts: Add exynos5250-spring device tree Andreas Färber
2014-08-01 5:16 ` [PATCH v5 00/10] ARM: dts: exynos: Prepare Spring Andreas Färber
2014-08-01 21:07 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DC00B8.3050008@gmail.com \
--to=tomasz.figa@gmail.com \
--cc=afaerber@suse.de \
--cc=ben-linux@fluff.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=javier.martinez@collabora.co.uk \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=stephan@synkhronix.com \
--cc=t.figa@samsung.com \
--cc=vpalatin@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).