From: Michal Simek <monstr@monstr.eu>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Srikanth Thokala <sthokal@xilinx.com>,
Arnd Bergmann <arnd@arndb.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
svemula@xilinx.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Michal Simek <michal.simek@xilinx.com>,
Grant Likely <grant.likely@linaro.org>,
anirudh@xilinx.com
Subject: Re: [PATCH v5] pcie: Add Xilinx PCIe Host Bridge IP driver
Date: Tue, 12 Aug 2014 11:37:22 +0200 [thread overview]
Message-ID: <53E9E052.3070308@monstr.eu> (raw)
In-Reply-To: <CA+mB=1LeZn1k2VHNby2TRBcb1xuFFTQio=C845_xe2A=ZciYqg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1713 bytes --]
Hi Bjorn,
On 07/30/2014 01:24 PM, Srikanth Thokala wrote:
> Hi Arnd,
>
> On Mon, Jul 28, 2014 at 6:32 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>> On Monday 28 July 2014 18:04:34 Srikanth Thokala wrote:
>>> Hi Arnd and Rob,
>>>
>>> I discussed with Bjorn and we believe this patch is in good shape to
>>> apply. And Bjorn requires ACKs to apply this patch. So, could you
>>> guys please review this patch and provided your ACKs to this patch.
>>
>> Looks great for the most part. I've looked through the whole driver
>> again, and I have two small issues remaining:
>>
>> a) Please clarify in the changeset description why there is no support
>> for PCI I/O space.
>
> Sure, I will add to my changeset.
>
>>
>> b) I think you should use the 'msi-parent' property, and the
>> of_pci_find_msi_chip_by_node() to find the msi_chip for the
>> PCI controller. This will make it possible to forward MSIs
>> to the main interrupt controller in the system, which is more
>> efficient. See the pcie-mvebu driver for an example of this.
>
> Ok, I need to look into this and I will plan to implement on top of this patch.
>
>>
>> Other than these:
>>
>> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> Thanks Arnd for the Ack.
What's the status on this one?
Srikanth:
Isn't pcie-xilinx.c better name if this is just pcie host bridge?
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2014-08-12 9:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 16:03 [PATCH v5] pcie: Add Xilinx PCIe Host Bridge IP driver Srikanth Thokala
2014-07-28 12:34 ` Srikanth Thokala
[not found] ` <CA+mB=1JhDF=BBXcyTbgVB8S7qH=Mb1JH78HLL4pA9OBH19hQvA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-28 13:02 ` Arnd Bergmann
2014-07-30 11:24 ` Srikanth Thokala
2014-08-12 9:37 ` Michal Simek [this message]
2014-08-18 9:17 ` Srikanth Thokala
2014-08-18 18:49 ` Bjorn Helgaas
2014-08-20 12:13 ` Srikanth Thokala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E9E052.3070308@monstr.eu \
--to=monstr@monstr.eu \
--cc=anirudh@xilinx.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=sthokal@xilinx.com \
--cc=svemula@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).