From: Stephen Boyd <sboyd@codeaurora.org>
To: Stepan Moskovchenko <stepanm@codeaurora.org>
Cc: grant.likely@linaro.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] of: Deep-copy names of platform devices
Date: Tue, 12 Aug 2014 18:46:36 -0700 [thread overview]
Message-ID: <53EAC37C.4020203@codeaurora.org> (raw)
In-Reply-To: <1407891444-7311-1-git-send-email-stepanm@codeaurora.org>
On 08/12/14 17:57, Stepan Moskovchenko wrote:
> diff --git a/drivers/of/device.c b/drivers/of/device.c
> index f685e55..3e116f6 100644
> --- a/drivers/of/device.c
> +++ b/drivers/of/device.c
> @@ -54,7 +54,7 @@ int of_device_add(struct platform_device *ofdev)
>
> /* name and id have to be set so that the platform bus doesn't get
> * confused on matching */
> - ofdev->name = dev_name(&ofdev->dev);
> + ofdev->name = kstrdup(dev_name(&ofdev->dev), GFP_KERNEL);
> ofdev->id = -1;
>
> /* device_add will assume that this device is on the same node as
> @@ -76,6 +76,7 @@ EXPORT_SYMBOL(of_device_register);
> void of_device_unregister(struct platform_device *ofdev)
> {
> device_unregister(&ofdev->dev);
> + kfree(ofdev->name);
This probably ought to be swapped because we don't know if ofdev isn't
pointing to freed memory after device_unregister().
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-08-13 1:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 0:57 [PATCH] of: Deep-copy names of platform devices Stepan Moskovchenko
2014-08-13 1:46 ` Stephen Boyd [this message]
2014-08-13 2:30 ` [PATCH v2] " Stepan Moskovchenko
2014-08-15 16:38 ` Rob Herring
2014-08-16 4:19 ` Greg Kroah-Hartman
2014-08-16 18:29 ` Grant Likely
2014-08-15 10:45 ` [PATCH] " Grant Likely
2014-08-15 10:52 ` Grant Likely
[not found] ` <CACxGe6tr_hX+XBD=C+y55OixrweVLZvNNFQHxSDHwuHbSYW-XQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-08-15 11:01 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EAC37C.4020203@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stepanm@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).