From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dinh Nguyen Subject: Re: [PATCHv2 3/3] ARM: dts: socfpga: memreserve first 4KB for SMP code Date: Fri, 15 Aug 2014 08:43:23 -0500 Message-ID: <53EE0E7B.4010208@opensource.altera.com> References: <1408050814-28595-1-git-send-email-dinguyen@opensource.altera.com> <1408050814-28595-4-git-send-email-dinguyen@opensource.altera.com> <20140815112758.GE15621@leverpostej> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140815112758.GE15621@leverpostej> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Rutland Cc: "dinh.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org" , "galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org" , Pawel Moll , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org" , "tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org" , "vbridger-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org" List-Id: devicetree@vger.kernel.org Hi Mark, On 8/15/14, 6:27 AM, Mark Rutland wrote: > Hi Dinh, > > On Thu, Aug 14, 2014 at 10:13:34PM +0100, dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org wrote: >> From: Dinh Nguyen >> >> The SOCFPGA's SMP code uses 0x0 for as the location for the trampoline to >> bring secondary cores online. This patch adds a /memreserve/ section to >> reserve the first 4K for the SMP trampoline code. > > I'm slightly confused. > > Sorry to split hairs here, but I think the comment is subtly wrong. > > The trampoline code seems to be placed in this location by Linux, so > it's not that we're protecting the trampoline code, but rather we're > preserving the location for future use. Yes, you're correct. Preserving this location for possible copying of the trampoline code for SMP usage is more of a correct statement. > > I take it that the reset address isn't configurable? No, I don't believe it is on this platform. Thanks for the review. I will spin a V3 with an updated commit message. Dinh -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html