From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v5 3/5] usb: host: ehci-st: Add ehci-st devicetree bindings documentation Date: Fri, 15 Aug 2014 18:47:15 +0400 Message-ID: <53EE1D73.6030006@cogentembedded.com> References: <1408111410-14375-1-git-send-email-peter.griffin@linaro.org> <1408111410-14375-4-git-send-email-peter.griffin@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1408111410-14375-4-git-send-email-peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peter Griffin , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, srinivas.kandagatla-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, maxime.coquelin-qxv4g6HH51o@public.gmane.org, patrice.chotard-qxv4g6HH51o@public.gmane.org Cc: lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hello. On 08/15/2014 06:03 PM, Peter Griffin wrote: > This patch documents the device tree bindings required for the > ehci on-chip controller found in ST consumer electronics SoC's. > Signed-off-by: Peter Griffin > --- > Documentation/devicetree/bindings/usb/ehci-st.txt | 39 +++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/ehci-st.txt > diff --git a/Documentation/devicetree/bindings/usb/ehci-st.txt b/Documentation/devicetree/bindings/usb/ehci-st.txt > new file mode 100644 > index 0000000..fb45fa5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/ehci-st.txt > @@ -0,0 +1,39 @@ > +ST USB EHCI controller > + > +Required properties: > + - compatible : must be "st,st-ehci-300x" > + - reg : physical base addresses of the controller and length of memory mapped > + region > + - interrupts : one EHCI interrupt should be described here > + - pinctrl-names : a pinctrl state named "default" must be defined > + - pinctrl-0 : phandle referencing pin configuration of the USB controller > +See: Documentation/devicetree/bindings/pinctrl/pinctrl-binding.txt > + - clocks : phandle list of usb clocks > + - clock-names : should be "ic" for interconnect clock and "clk48" This sentence seems unfinished? > +See: Documentation/devicetree/bindings/clock/clock-bindings.txt > + > + - phys : phandle for the PHY device > + - phy-names : should be "usb" > + - resets : phandle + reset specifier pairs to the powerdown and softreset lines > + of the USB IP > + - reset-names : should be "power" and "softreset" > +See: Documentation/devicetree/bindings/reset/st,sti-powerdown.txt > +See: Documentation/devicetree/bindings/reset/reset.txt > + > +Example: > + > + ehci1: usb@0xfe203e00 { > + compatible = "st,st-ehci-300x"; > + reg = <0xfe203e00 0x100>; > + interrupts = ; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usb1>; > + clocks = <&clk_s_a1_ls 0>; You said that "clock-names" is a required prop but you didn't specify it. > + phys = <&usb2_phy>; > + phy-names = "usb"; > + status = "okay"; Not necessary. > + > + resets = <&powerdown STIH416_USB1_POWERDOWN>, > + <&softreset STIH416_USB1_SOFTRESET>; > + reset-names = "power", "softreset"; > + }; WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html