From: David Daney <ddaney.cavm@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Andrew Bresticker <abrestic@chromium.org>,
Kumar Gala <galak@codeaurora.org>,
Ralf Baechle <ralf@linux-mips.org>,
David Daney <david.daney@cavium.com>,
Rob Herring <robh+dt@kernel.org>,
Linux-MIPS <linux-mips@linux-mips.org>,
Qais Yousef <qais.yousef@imgtec.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
John Crispin <blogic@openwrt.org>,
Mark Rutland <mark.rutland@arm.com>,
Jayachandran C <jchandra@broadcom.com>,
Paul Burton <paul.burton@imgtec.com>,
James Hogan <james.hogan@imgtec.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 0/7] MIPS: Move device-tree files to a common location
Date: Fri, 22 Aug 2014 13:57:16 -0700 [thread overview]
Message-ID: <53F7AEAC.90303@gmail.com> (raw)
In-Reply-To: <CAGVrzcZobuL4z0WNX+Sz4p_uwaPL-S5yvEmgRUwZPJi4+qq0tg@mail.gmail.com>
On 08/22/2014 01:42 PM, Florian Fainelli wrote:
> On Aug 21, 2014 3:05 PM, "Andrew Bresticker" <abrestic@chromium.org
> <mailto:abrestic@chromium.org>> wrote:
> >
> > To be consistent with other architectures and to avoid unnecessary
> > makefile duplication, move all MIPS device-trees to arch/mips/boot/dts
> > and build them with a common makefile.
>
> I recall reading that the ARM organization for DTS files was a bit
> unfortunate and should have been something like:
>
> arch/arm/boot/dts/<vendor>/
>
> Is this something we should do for the MIPS and update the other
> architectures to follow that scheme?
If we choose not to intermingle .dts files from all the vendors in a
single directory, why do anything at all? Currently the .dts files for
a vendor are nicely segregated with the rest of the vendors code under a
single directory.
Personally I think things are fine as they are. Any common code
remaining in the Makefiles could be moved to the scripts directory for a
smaller change.
>
> >
> > Patch 1 sets up the makefiles for building the DTs in arch/mips/boot/dts
> > and introduces the config option BUILTIN_DTB for platforms that require
> > it.
> >
> > Patch 2 introduces the 'dtbs' makefile target to allow building of just
> > the DT binaries.
> >
> > Patches 3-7 move the DTs out of the platform directores.
> >
> > I've build tested this on all affected platforms (Octeon, Lantiq, SEAD3,
> > Netlogic, and Ralink) as well as Malta. For platforms where builtin DTBs
> > are optional (Netlogic and Ralink), I built with and without the builtin
> > DTBs.
> >
> > Based on 3.17-rc1.
> >
> > Andrew Bresticker (7):
> > MIPS: Create common infrastructure for building built-in device-trees
> > MIPS: Add support for building device-tree binaries
> > MIPS: Octeon: Move device-trees to arch/mips/boot/dts/
> > MIPS: Lantiq: Move device-trees to arch/mips/boot/dts/
> > MIPS: sead3: Move device-trees to arch/mips/boot/dts/
> > MIPS: Netlogic: Move device-trees to arch/mips/boot/dts/
> > MIPS: ralink: Move device-trees to arch/mips/boot/dts/
> >
> > arch/mips/Kconfig | 5 +++++
> > arch/mips/Makefile | 11 +++++++++++
> > arch/mips/boot/.gitignore | 1 +
> > arch/mips/boot/dts/Makefile | 20
> ++++++++++++++++++++
> > arch/mips/{lantiq => boot}/dts/danube.dtsi | 0
> > arch/mips/{lantiq => boot}/dts/easy50712.dts | 0
> > arch/mips/{ralink => boot}/dts/mt7620a.dtsi | 0
> > arch/mips/{ralink => boot}/dts/mt7620a_eval.dts | 0
> > .../mips/{cavium-octeon => boot/dts}/octeon_3xxx.dts | 0
> > .../mips/{cavium-octeon => boot/dts}/octeon_68xx.dts | 0
> > arch/mips/{ralink => boot}/dts/rt2880.dtsi | 0
> > arch/mips/{ralink => boot}/dts/rt2880_eval.dts | 0
> > arch/mips/{ralink => boot}/dts/rt3050.dtsi | 0
> > arch/mips/{ralink => boot}/dts/rt3052_eval.dts | 0
> > arch/mips/{ralink => boot}/dts/rt3883.dtsi | 0
> > arch/mips/{ralink => boot}/dts/rt3883_eval.dts | 0
> > arch/mips/{mti-sead3 => boot/dts}/sead3.dts | 0
> > arch/mips/{netlogic => boot}/dts/xlp_evp.dts | 0
> > arch/mips/{netlogic => boot}/dts/xlp_fvp.dts | 0
> > arch/mips/{netlogic => boot}/dts/xlp_gvp.dts | 0
> > arch/mips/{netlogic => boot}/dts/xlp_svp.dts | 0
> > arch/mips/cavium-octeon/.gitignore | 2 --
> > arch/mips/cavium-octeon/Makefile | 10 ----------
> > arch/mips/lantiq/Kconfig | 1 +
> > arch/mips/lantiq/Makefile | 2 --
> > arch/mips/lantiq/dts/Makefile | 1 -
> > arch/mips/mti-sead3/Makefile | 4 ----
> > arch/mips/netlogic/Kconfig | 4 ++++
> > arch/mips/netlogic/Makefile | 1 -
> > arch/mips/netlogic/dts/Makefile | 4 ----
> > arch/mips/ralink/Kconfig | 4 ++++
> > arch/mips/ralink/Makefile | 2 --
> > arch/mips/ralink/dts/Makefile | 4 ----
> > 33 files changed, 46 insertions(+), 30 deletions(-)
> > create mode 100644 arch/mips/boot/dts/Makefile
> > rename arch/mips/{lantiq => boot}/dts/danube.dtsi (100%)
> > rename arch/mips/{lantiq => boot}/dts/easy50712.dts (100%)
> > rename arch/mips/{ralink => boot}/dts/mt7620a.dtsi (100%)
> > rename arch/mips/{ralink => boot}/dts/mt7620a_eval.dts (100%)
> > rename arch/mips/{cavium-octeon => boot/dts}/octeon_3xxx.dts (100%)
> > rename arch/mips/{cavium-octeon => boot/dts}/octeon_68xx.dts (100%)
> > rename arch/mips/{ralink => boot}/dts/rt2880.dtsi (100%)
> > rename arch/mips/{ralink => boot}/dts/rt2880_eval.dts (100%)
> > rename arch/mips/{ralink => boot}/dts/rt3050.dtsi (100%)
> > rename arch/mips/{ralink => boot}/dts/rt3052_eval.dts (100%)
> > rename arch/mips/{ralink => boot}/dts/rt3883.dtsi (100%)
> > rename arch/mips/{ralink => boot}/dts/rt3883_eval.dts (100%)
> > rename arch/mips/{mti-sead3 => boot/dts}/sead3.dts (100%)
> > rename arch/mips/{netlogic => boot}/dts/xlp_evp.dts (100%)
> > rename arch/mips/{netlogic => boot}/dts/xlp_fvp.dts (100%)
> > rename arch/mips/{netlogic => boot}/dts/xlp_gvp.dts (100%)
> > rename arch/mips/{netlogic => boot}/dts/xlp_svp.dts (100%)
> > delete mode 100644 arch/mips/cavium-octeon/.gitignore
> > delete mode 100644 arch/mips/lantiq/dts/Makefile
> > delete mode 100644 arch/mips/netlogic/dts/Makefile
> > delete mode 100644 arch/mips/ralink/dts/Makefile
> >
> > --
> > 2.1.0.rc2.206.gedb03e5
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe devicetree" in
> > the body of a message to majordomo@vger.kernel.org
> <mailto:majordomo@vger.kernel.org>
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-08-22 20:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 20:04 [PATCH 0/7] MIPS: Move device-tree files to a common location Andrew Bresticker
2014-08-21 20:04 ` [PATCH 1/7] MIPS: Create common infrastructure for building built-in device-trees Andrew Bresticker
2014-08-21 20:04 ` [PATCH 3/7] MIPS: Octeon: Move device-trees to arch/mips/boot/dts/ Andrew Bresticker
[not found] ` <1408651466-8334-1-git-send-email-abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-08-21 20:04 ` [PATCH 2/7] MIPS: Add support for building device-tree binaries Andrew Bresticker
2014-08-21 20:04 ` [PATCH 4/7] MIPS: Lantiq: Move device-trees to arch/mips/boot/dts/ Andrew Bresticker
2014-08-21 20:04 ` [PATCH 5/7] MIPS: sead3: " Andrew Bresticker
2014-08-21 20:04 ` [PATCH 6/7] MIPS: Netlogic: " Andrew Bresticker
2014-08-21 20:04 ` [PATCH 7/7] MIPS: ralink: " Andrew Bresticker
2014-08-22 20:42 ` [PATCH 0/7] MIPS: Move device-tree files to a common location Florian Fainelli
2014-08-22 20:57 ` David Daney [this message]
2014-08-22 22:10 ` Andrew Bresticker
2014-08-22 23:16 ` Jonas Gorski
[not found] ` <CAOiHx=kLfKLZA2Nv+dn87S50209DBXRj8OgZsywXQ0MoqTVA8A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-08-23 0:24 ` Andrew Bresticker
2014-08-22 21:10 ` Andrew Bresticker
2014-08-23 6:31 ` Olof Johansson
2014-08-23 13:56 ` Arnd Bergmann
[not found] ` <201408231556.42571.arnd-r2nGTMty4D4@public.gmane.org>
2014-08-23 14:48 ` Jonas Gorski
[not found] ` <CAOiHx=noe=614vv4GyhuvfoAYj0jYDhO5vX+7M2RbQBpE-uPnQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-08-23 14:59 ` Arnd Bergmann
2014-08-23 16:14 ` Olof Johansson
2014-08-24 23:43 ` Rob Herring
2014-08-25 8:12 ` Arnd Bergmann
2014-08-25 14:49 ` Ralf Baechle
2014-08-23 19:50 ` Geert Uytterhoeven
[not found] ` <CAMuHMdXudu0kuOkKN8JCrWZSrQ4awKHhHU0E2ss++ProP0rteQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-08-25 15:17 ` Jonas Gorski
[not found] ` <CAOiHx=mZPt=p_jw4fyEqgniJvqunQ86ro_Run5ZtD1zLYWzmqA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-08-25 15:26 ` Geert Uytterhoeven
2014-08-27 18:30 ` Andrew Bresticker
[not found] ` <CAL1qeaFTw=0XMEkag1Z8C4jKkWnwBeGJLYxHGiYfKXBk-9o0Yw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-08-27 19:33 ` David Daney
2014-08-28 15:04 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F7AEAC.90303@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=abrestic@chromium.org \
--cc=blogic@openwrt.org \
--cc=david.daney@cavium.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=james.hogan@imgtec.com \
--cc=jchandra@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mark.rutland@arm.com \
--cc=paul.burton@imgtec.com \
--cc=pawel.moll@arm.com \
--cc=qais.yousef@imgtec.com \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).