From: "Andreas Färber" <afaerber@suse.de>
To: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Kukjin Kim <kgene.kim@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] phy: exynos5-usbdrd: Add MODULE_DEVICE_TABLE entry
Date: Sat, 23 Aug 2014 18:23:15 +0200 [thread overview]
Message-ID: <53F8BFF3.8020001@suse.de> (raw)
In-Reply-To: <1408715892-27728-1-git-send-email-sjoerd.simons@collabora.co.uk>
Hi,
Am 22.08.2014 15:58, schrieb Sjoerd Simons:
> Add a MODULE_DEVICE_TABLE call for OF match tables. This allows the
> module to be autoloaded based on devicetree information.
>
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> ---
> drivers/phy/phy-exynos5-usbdrd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/phy/phy-exynos5-usbdrd.c b/drivers/phy/phy-exynos5-usbdrd.c
> index b05302b..e9a0f54 100644
> --- a/drivers/phy/phy-exynos5-usbdrd.c
> +++ b/drivers/phy/phy-exynos5-usbdrd.c
> @@ -542,6 +542,7 @@ static const struct of_device_id exynos5_usbdrd_phy_of_match[] = {
> },
> { },
> };
> +MODULE_DEVICE_TABLE (of, exynos5_usbdrd_phy_of_match);
Nit: Probably there should be no space before '('?
>
> static int exynos5_usbdrd_phy_probe(struct platform_device *pdev)
> {
Otherwise certainly sensible. I ran into another such case myself.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2014-08-23 16:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 13:58 [PATCH] phy: exynos5-usbdrd: Add MODULE_DEVICE_TABLE entry Sjoerd Simons
2014-08-23 16:23 ` Andreas Färber [this message]
2014-08-25 7:38 ` [PATCH v2] " Sjoerd Simons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F8BFF3.8020001@suse.de \
--to=afaerber@suse.de \
--cc=devicetree@vger.kernel.org \
--cc=kgene.kim@samsung.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sjoerd.simons@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).