From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Zhong Subject: Re: [PATCH v2 2/5] MFD: RK808: Add new mfd driver for RK808 Date: Tue, 26 Aug 2014 20:37:30 +0800 Message-ID: <53FC7F8A.2050903@rock-chips.com> References: <1408505461-24200-1-git-send-email-zyw@rock-chips.com> <20140820092117.GI4266@lee--X1> <53FA9D1E.8040202@rock-chips.com> <20140826092205.GG9574@lee--X1> <53FC5BD1.7030406@rock-chips.com> <20140826102036.GJ9574@lee--X1> <53FC63EE.6060104@rock-chips.com> <20140826112013.GK9574@lee--X1> <53FC77F0.4030004@rock-chips.com> <20140826122304.GA26707@lee--X1> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140826122304.GA26707@lee--X1> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lee Jones Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org, mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org, huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org, cf-TNX95d0MmH7DzftRWevZcw@public.gmane.org, zhangqing-TNX95d0MmH7DzftRWevZcw@public.gmane.org, xxx-TNX95d0MmH7DzftRWevZcw@public.gmane.org, dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org, olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org, sonnyrao-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, dtor-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org, kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org List-Id: devicetree@vger.kernel.org On 08/26/2014 08:23 PM, Lee Jones wrote: > On Tue, 26 Aug 2014, Chris Zhong wrote: >> On 08/26/2014 07:20 PM, Lee Jones wrote: >>> On Tue, 26 Aug 2014, Chris Zhong wrote: >>>> On 08/26/2014 06:20 PM, Lee Jones wrote: >>>>> On Tue, 26 Aug 2014, Chris Zhong wrote: >>>>>> On 08/26/2014 05:22 PM, Lee Jones wrote: >>>>>>> On Mon, 25 Aug 2014, Chris Zhong wrote: >>>>>>>> On 08/20/2014 05:21 PM, Lee Jones wrote: >>>>>>>>> On Wed, 20 Aug 2014, Chris Zhong wrote: >>>>>>>>> >>>>>>>>>> The RK808 chip is a power management IC for multimedia and handheld >>>>>>>>>> devices. It contains the following components: >>>>>>>>>> >>>>>>>>>> - Regulators >>>>>>>>>> - RTC >>>>>>>>>> >>>>>>>>>> The rk808 core driver is registered as a platform driver and provides >>>>>>>>>> communication through I2C with the host device for the different >>>>>>>>>> components. >>>>>>>>>> >>>>>>>>>> Signed-off-by: Chris Zhong >>>>>>>>>> --- >>>>>>> [...] >>>>>>> >>>>>>>>>> + rk808->pdata = pdata; >>>>>>>>> Remove pdata from 'struct rk808'. You can obtain it from dev. >>>>>>>> Can I keep this pdata in rk808, because it is used in the regulator driver. >>>>>>>> The one obtain from dev maybe empty. >>>>>>> If the one in dev is empty, you should populate that instead. >>>>>> So, should I malloc a pada, and assign it to client->dev? >>>>> If client->dev.pdata is NULL, yes. >>>>> >>>>> But actually, I have more important questions that need to be answered >>>>> first. Ones which I would normally be able to answer myself if the >>>>> patch-set had been sent as one (i.e. threaded) instead of as >>>>> individual patches: >>>>> >>>>> - What are you using pdata for? >>>> For save some properties, >>>> >>>> like "rockchip,system-power-controller" in MFD >>>> and some regulator properties in regulator/rk808... >>>> >>>>> - Where is pdata populated? >>>> It is populated in probe in mfd/rk808.c >>>> >>>> actually, I copy it from tps65910.c >>>> >>>> >>>>> - Where is pdata used? >>>> pdata is used in mfd and regulator >>> I'm still a little confused. I see it being populated in the MFD >>> driver, then I only see the attributes populated in the MFD driver >>> used in the MFD driver and nowhere else? I do see other attributes >>> used in the regulator driver i.e. .of_node[], but these are then used >>> only in the regulator driver, thus they shouldn't really be pdata. >>> >>> Let me put it another way: >>> >>> struct rk808_board { >>> + int irq; >>> + int irq_base; >>> + int wakeup; >>> + bool pm_off; >>> + struct regulator_init_data *rk808_init_data[rk808_NUM_REGULATORS]; >>> + struct device_node *of_node[rk808_NUM_REGULATORS]; >>> + int pmic_sleep_gpio; >>> + unsigned int dcdc_slp_voltage[3]; /* buckx_voltage in uV */ >>> + unsigned int ldo_slp_voltage[7]; >>> +}; >>> >>> For each of the above: >>> >>> - Can it be passed from platform data i.e. arch//{plat,mach}-*? >>> - Can it use local (not passed from driver to driver) variable instead? >>> >>> If the answer to the first question is 'no' and/or if the answer to >>> the second question is 'yes', then it shouldn't be platform data. >> Yes, if we have no dts file, these value can pass from mach-rk***. >> >> It can be filled with all user setting of rk808, in a struct. >> >> the latest struct is: >> >> struct rk808_board { >> >> int wakeup; >> >> bool pm_off; >> >> struct regulator_init_data *rk808_init_data[RK808_NUM_REGULATORS]; >> >> struct device_node *of_node[RK808_NUM_REGULATORS]; >> >> unsigned int dcdc_slp_voltage[3]; /* buckx_voltage in uV */ >> >> unsigned int ldo_slp_voltage[7]; >> >> }; > This version looks much more acceptable. > > Although, I am concerned about of_node[]. Isn't that only populated > and used in the regulator driver? Yes, it only used in regulator driver Well, it might be better to delete the pdata from MFD. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html