devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dinh Nguyen <dinh.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Zhangfei Gao
	<zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	haojian.zhuang-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	haifeng.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	jchxue-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org
Cc: Jiancheng Xue
	<xuejiancheng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v2 6/6] ARM: dts: hix5hd2: add wdg node
Date: Thu, 28 Aug 2014 04:21:43 -0500	[thread overview]
Message-ID: <53FEF4A7.2040001@gmail.com> (raw)
In-Reply-To: <1409204060-9223-7-git-send-email-zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>



On 8/28/14, 12:34 AM, Zhangfei Gao wrote:
> Signed-off-by: Jiancheng Xue <xuejiancheng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Zhangfei Gao <zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
>  arch/arm/boot/dts/hisi-x5hd2.dtsi |    9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/hisi-x5hd2.dtsi b/arch/arm/boot/dts/hisi-x5hd2.dtsi
> index 152f3ad..7b1cb53 100644
> --- a/arch/arm/boot/dts/hisi-x5hd2.dtsi
> +++ b/arch/arm/boot/dts/hisi-x5hd2.dtsi
> @@ -365,6 +365,15 @@
>  				#interrupt-cells = <2>;
>  				status = "disabled";
>  			};
> +
> +			wdg0: wdg@a2c000 {

A nit-pick here, but everybody else is using 'wdt' for a watchdog timer
node.

> +				compatible = "arm,sp805", "arm,primecell";

I didn't see an entry for "arm,sp805" in Documentations, should there be
one?

Dinh
> +				arm,primecell-periphid = <0x00141805>;
> +				reg = <0xa2c000 0x1000>;
> +				interrupts = <0 29 4>;
> +				clocks = <&clock HIX5HD2_WDG0_RST>;
> +				clock-names = "apb_pclk";
> +                       };
>  		};
>  
>  		local_timer@00a00600 {
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2014-08-28  9:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-28  5:34 [PATCH v2 0/6] hix5hd2 add some nodes Zhangfei Gao
     [not found] ` <1409204060-9223-1-git-send-email-zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-08-28  5:34   ` [PATCH v2 1/6] ARM: dts: hix5hd2: add gmac node Zhangfei Gao
2014-08-28  5:34   ` [PATCH v2 2/6] ARM: dts: hix5hd2: add mmc node Zhangfei Gao
2014-08-28  5:34   ` [PATCH v2 3/6] ARM: dts: hix5hd2: add usb node Zhangfei Gao
2014-08-28  5:34   ` [PATCH v2 4/6] ARM: dts: hix5hd2: add sata node Zhangfei Gao
2014-08-28  5:34   ` [PATCH v2 5/6] ARM: dts: hix5hd2: add gpio node Zhangfei Gao
2014-08-28  5:34   ` [PATCH v2 6/6] ARM: dts: hix5hd2: add wdg node Zhangfei Gao
     [not found]     ` <1409204060-9223-7-git-send-email-zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-08-28  9:21       ` Dinh Nguyen [this message]
     [not found]         ` <53FEF4A7.2040001-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-28 17:12           ` Mark Rutland
2014-08-29  8:12             ` zhangfei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53FEF4A7.2040001@gmail.com \
    --to=dinh.linux-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=haifeng.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=haojian.zhuang-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=jchxue-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=xuejiancheng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    --cc=xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org \
    --cc=zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).