Fwd: [PATCH] x86/devicetree: Fix compile warnings on AMD64

Fwd: [PATCH] x86/devicetree: Fix compile warnings on AMD64

[Ricardo Ribalda Delgado]

---------- Forwarded message ----------
From: Ricardo Ribalda Delgado <ricardo.ribalda-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date: Tue, Aug 5, 2014 at 11:19 AM
Subject: [PATCH] x86/devicetree: Fix compile warnings on AMD64
To: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>, Ingo Molnar
<mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, "H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
Grant Likely <grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Michal Simek <monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org>, Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Ricardo Ribalda Delgado <ricardo.ribalda-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>


arch/x86/kernel/devicetree.c: In function ‘ioapic_xlate’:
arch/x86/kernel/devicetree.c:294:8: warning: cast from pointer to
integer of different size [-Wpointer-to-int-cast]
  idx = (__force u32) domain->host_data;
        ^
arch/x86/kernel/devicetree.c: In function ‘dt_add_ioapic_domain’:
arch/x86/kernel/devicetree.c:323:4: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
    (void *)ioapic_num);

Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 arch/x86/kernel/devicetree.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/devicetree.c b/arch/x86/kernel/devicetree.c
index 7db54b5..a481d1b 100644
--- a/arch/x86/kernel/devicetree.c
+++ b/arch/x86/kernel/devicetree.c
@@ -278,7 +278,8 @@ static int ioapic_xlate(struct irq_domain *domain,
 {
        struct io_apic_irq_attr attr;
        struct of_ioapic_type *it;
-       u32 line, idx;
+       u32 line;
+       unsigned long idx;
        int rc;

        if (WARN_ON(intsize < 2))
@@ -291,7 +292,7 @@ static int ioapic_xlate(struct irq_domain *domain,

        it = &of_ioapic_type[intspec[1]];

-       idx = (u32) domain->host_data;
+       idx = (unsigned long) domain->host_data;
        set_io_apic_irq_attr(&attr, idx, line, it->trigger, it->polarity);

        rc = io_apic_setup_irq_pin_once(irq_find_mapping(domain, line),
@@ -320,7 +321,7 @@ static void dt_add_ioapic_domain(unsigned int ioapic_num,
        num = gsi_cfg->gsi_end - gsi_cfg->gsi_base + 1;

        id = irq_domain_add_linear(np, num, &ioapic_irq_domain_ops,
-                       (void *)ioapic_num);
+                       (void *)((unsigned long)ioapic_num));
        BUG_ON(!id);
        if (gsi_cfg->gsi_base == 0) {
                /*
--
2.0.1



-- 
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Fwd: [PATCH] x86/devicetree: Fix compile warnings on AMD64

[Sebastian Andrzej Siewior]

On 08/28/2014 03:04 PM, Ricardo Ribalda Delgado wrote:
> ---------- Forwarded message ----------
> From: Ricardo Ribalda Delgado <ricardo.ribalda-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Date: Tue, Aug 5, 2014 at 11:19 AM
> Subject: [PATCH] x86/devicetree: Fix compile warnings on AMD64
> To: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>, Ingo Molnar
> <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, "H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
> Grant Likely <grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
> Michal Simek <monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org>, Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
> linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Cc: Ricardo Ribalda Delgado <ricardo.ribalda-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

⇑
this makes it not a valid patch submission.

> arch/x86/kernel/devicetree.c: In function ‘ioapic_xlate’:
> arch/x86/kernel/devicetree.c:294:8: warning: cast from pointer to
> integer of different size [-Wpointer-to-int-cast]
>   idx = (__force u32) domain->host_data;
>         ^
> arch/x86/kernel/devicetree.c: In function ‘dt_add_ioapic_domain’:
> arch/x86/kernel/devicetree.c:323:4: warning: cast to pointer from
> integer of different size [-Wint-to-pointer-cast]
>     (void *)ioapic_num);
> 
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

while the patch fixes the type cast warnings, it makes me wonder: How
did you enable it on 64bit? Both platforms (that is CE4100 and OLPC)
are 32bit only.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Fwd: [PATCH] x86/devicetree: Fix compile warnings on AMD64

[Ricardo Ribalda Delgado]

Hello Sebastian

On Thu, Aug 28, 2014 at 3:13 PM, Sebastian Andrzej Siewior
<bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org> wrote:
> On 08/28/2014 03:04 PM, Ricardo Ribalda Delgado wrote:
>> ---------- Forwarded message ----------
>> From: Ricardo Ribalda Delgado <ricardo.ribalda-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> Date: Tue, Aug 5, 2014 at 11:19 AM
>> Subject: [PATCH] x86/devicetree: Fix compile warnings on AMD64
>> To: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>, Ingo Molnar
>> <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, "H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
>> Grant Likely <grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
>> Michal Simek <monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org>, Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
>> linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> Cc: Ricardo Ribalda Delgado <ricardo.ribalda-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> ⇑
> this makes it not a valid patch submission.

The problem is that it is a fwd message?  I did send it first the 5th
of August and did not get any feedback, this is why I tried to
different destinations. Shall I just resend it?

>
>> arch/x86/kernel/devicetree.c: In function ‘ioapic_xlate’:
>> arch/x86/kernel/devicetree.c:294:8: warning: cast from pointer to
>> integer of different size [-Wpointer-to-int-cast]
>>   idx = (__force u32) domain->host_data;
>>         ^
>> arch/x86/kernel/devicetree.c: In function ‘dt_add_ioapic_domain’:
>> arch/x86/kernel/devicetree.c:323:4: warning: cast to pointer from
>> integer of different size [-Wint-to-pointer-cast]
>>     (void *)ioapic_num);
>>
>> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> while the patch fixes the type cast warnings, it makes me wonder: How
> did you enable it on 64bit? Both platforms (that is CE4100 and OLPC)
> are 32bit only.
>
> Sebastian

I am working on an fpga camera (http://qtec.com) connected via pcie to
an amd fusion APU (64 bits). The hardware of the fpga is described
with devicetrees.


Thanks!



-- 
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Fwd: [PATCH] x86/devicetree: Fix compile warnings on AMD64

[Sebastian Andrzej Siewior]

On 08/28/2014 03:23 PM, Ricardo Ribalda Delgado wrote:
> The problem is that it is a fwd message?  I did send it first the 5th
Yes.

> of August and did not get any feedback, this is why I tried to
> different destinations. Shall I just resend it?

Usually you just add a RESEND / REPOST before the patch tag. The
forward header makes the submission useless (unless the TIP team has
time to manually edit the patch).

> I am working on an fpga camera (http://qtec.com) connected via pcie to
> an amd fusion APU (64 bits). The hardware of the fpga is described
> with devicetrees.

So you are telling me that there is (or will be) 64bit x86 hardware
which is using the device tree instead EFI, SFI or something like that.
Is that so?
If so it is worth mentioning that in the patch description that this
code is used on x86 hard which is not yet part of the kernel.
Either way, the x86 team + lkml is the destination that should apply
that patch so a proper repost (with the altered description I
mentioned) would be nice.

> Thanks!

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html