Re: [PATCH v3 1/3] rc: Add DT bindings for hix5hd2

[Varka Bhadram <varkabhadram@gmail.com>]

On 08/28/2014 08:46 PM, Zhangfei Gao wrote:
> From: Guoxiong Yan <yanguoxiong@huawei.com>
>
> Signed-off-by: Guoxiong Yan <yanguoxiong@huawei.com>
> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> ---
>   .../devicetree/bindings/media/hix5hd2-ir.txt       |   25 ++++++++++++++++++++
>   1 file changed, 25 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/media/hix5hd2-ir.txt
>
> diff --git a/Documentation/devicetree/bindings/media/hix5hd2-ir.txt b/Documentation/devicetree/bindings/media/hix5hd2-ir.txt
> new file mode 100644
> index 0000000..2bd88b9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/hix5hd2-ir.txt
> @@ -0,0 +1,25 @@
> +Device-Tree bindings for hix5hd2 ir IP
> +
> +Required properties:
> +- compatible: Should contain "hisilicon,hix5hd2-ir".
> +- reg: Base physical address of the controller and length of memory
> +  mapped region.
> +- interrupts: interrupt-specifier for the sole interrupt generated by
> +  the device. The interrupt specifier format depends on the interrupt
> +  controller parent.
> +- clocks: clock phandle and specifier pair.
> +- hisilicon,power-syscon: phandle of syscon used to control power.
> +

It would be readable if

Required properties:
- compatible		: Should contain "hisilicon,hix5hd2-ir".
- reg			: Base physical address of the controller and length of memory mapped region.
- interrupts		: interrupt-specifier for the sole interrupt generated by
			  the device. The interrupt specifier format depends on the interrupt
			  controller parent.
...

> +Optional properties:
> +- linux,rc-map-name : Remote control map name.
> +
> +Example node:
> +
> +	ir: ir@f8001000 {
> +		compatible = "hisilicon,hix5hd2-ir";
> +		reg = <0xf8001000 0x1000>;
> +		interrupts = <0 47 4>;
> +		clocks = <&clock HIX5HD2_FIXED_24M>;
> +		hisilicon,power-syscon = <&sysctrl>;
> +		linux,rc-map-name = "rc-tivo";
> +	};


-- 
Regards,
Varka Bhadram.