From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C28CCC6379F for ; Thu, 23 Feb 2023 08:59:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233787AbjBWI7u (ORCPT ); Thu, 23 Feb 2023 03:59:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233777AbjBWI7t (ORCPT ); Thu, 23 Feb 2023 03:59:49 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80D099038; Thu, 23 Feb 2023 00:59:48 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 38810B818EE; Thu, 23 Feb 2023 08:59:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57AA2C433EF; Thu, 23 Feb 2023 08:59:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677142785; bh=F0o0cKnSDpDn6p6gfaa0cgORZZdfAcpmNCptMtkWGMo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=cWrCNgIUCWybMOAM65p3P8Ow7EW0oV6gLvfnfB/z7oHJ4WQlBpGYoPSjRDxs75i1S /y3xaaYRQMn2K71c0cuM61aUdMHwjWbPme53J95CMuedEHrUlaM3mr1jnQFAdlLqGF 8V9TlH0NE9pOXcxb9J+90DFGde7JdY8JnkwV7R1PSD35KUKQKgLFjar5ohBDeR8H51 fZvVOZPXID4zCgXjav67l1hONvzxcmwfIA7sDGupVrVYmOZU/c96qPn5VUbYsTcDZG mdVKWcKM2oDD5VN7LHxgfIFWscSc80S1GGrsa98kDfX0rbqfg+Ws/+VF+CmLrfd5IV JdWA6tfarKVKQ== Message-ID: <53cc20a0-bc9d-a094-13bc-6a5ef78069d1@kernel.org> Date: Thu, 23 Feb 2023 09:59:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 1/2] Mips: ls2k1000: dts: add the display controller device node Content-Language: en-US To: suijingfeng , Thomas Zimmermann , David Airlie , Daniel Vetter , Rob Herring , Thomas Bogendoerfer Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20230222165514.684729-1-suijingfeng@loongson.cn> <32a56a81-e9b5-138b-4dff-35c2525cc0b6@loongson.cn> <6662546a-2c83-71bd-7050-903331201bdc@loongson.cn> From: Krzysztof Kozlowski In-Reply-To: <6662546a-2c83-71bd-7050-903331201bdc@loongson.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 23/02/2023 09:40, suijingfeng wrote: > > On 2023/2/23 15:58, Krzysztof Kozlowski wrote: >> On 23/02/2023 04:19, Sui jingfeng wrote: >>> Hi, >>> >>> On 2023/2/23 02:32, Krzysztof Kozlowski wrote: >>>> On 22/02/2023 17:55, suijingfeng wrote: >>>>> The display controller is a pci device, it's pci vendor id is >>>>> 0x0014, it's pci device id is 0x7a06. >>>>> >>>>> Signed-off-by: suijingfeng >>>>> --- >>>>> .../boot/dts/loongson/loongson64-2k1000.dtsi | 21 +++++++++++++++++++ >>>>> 1 file changed, 21 insertions(+) >>>>> >>>>> diff --git a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi >>>>> index 8143a61111e3..a528af3977d9 100644 >>>>> --- a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi >>>>> +++ b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi >>>>> @@ -31,6 +31,18 @@ memory@200000 { >>>>> <0x00000001 0x10000000 0x00000001 0xb0000000>; /* 6912 MB at 4352MB */ >>>>> }; >>>>> >>>>> + reserved-memory { >>>>> + #address-cells = <2>; >>>>> + #size-cells = <2>; >>>>> + ranges; >>>>> + >>>>> + display_reserved: framebuffer@30000000 { >>>>> + compatible = "shared-dma-pool"; >>>>> + reg = <0x0 0x30000000 0x0 0x04000000>; /* 64M */ >>>>> + linux,cma-default; >>>>> + }; >>>>> + }; >>>>> + >>>>> cpu_clk: cpu_clk { >>>>> #clock-cells = <0>; >>>>> compatible = "fixed-clock"; >>>>> @@ -198,6 +210,15 @@ sata@8,0 { >>>>> interrupt-parent = <&liointc0>; >>>>> }; >>>>> >>>>> + display-controller@6,0 { >>>>> + compatible = "loongson,ls2k1000-dc"; >>>>> + >>>>> + reg = <0x3000 0x0 0x0 0x0 0x0>; >>>>> + interrupts = <28 IRQ_TYPE_LEVEL_LOW>; >>>>> + interrupt-parent = <&liointc0>; >>>>> + memory-region = <&display_reserved>; >>>> NAK. >>> Err :(,  please give me a chance to explain >>>> Test your code against the bindings you send. >>> I can guarantee to you that I test may code more than twice. The code >>> used to testing is listed at link [1]. >> I wrote - test against the bindings. I don't believe that it was tested. >> Please paste the output of the testing (dtbs_check). ^^^^^^^^^^^^ Do you see this ----------^^^^? But you pasted: > > I *do* run the test against the bindings and the test result say nothing. > > I reset my modify today made, then re-run the test again. > > I'm telling the truth: the test result say nothing. I paste the log at > below: > > make -j$(nproc) ARCH=loongarch > CROSS_COMPILE=loongarch64-unknown-linux-gnu- dt_binding_check This -------------------------------------------^^^^^^^^^^^^ Best regards, Krzysztof