From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61656C4708E for ; Wed, 4 Jan 2023 01:32:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238359AbjADBcB (ORCPT ); Tue, 3 Jan 2023 20:32:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238710AbjADBb4 (ORCPT ); Tue, 3 Jan 2023 20:31:56 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26963117C; Tue, 3 Jan 2023 17:31:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description; bh=ijnis/WI5plp38mtmuFWM0btH8pvOuArfVZ6ZZO26+Y=; b=iATV2NXx5v9rrUgFhuJlontJxk TDxCgt5yG3Z5kdaUMpTB0ZUdrvYp+iO3lFYGnUPMv4jMQB973CMuMjbTtxgClc4+AI+uwNHvGKnS1 uN+whSmcWn322VWte3Is8JbIOEr9g6DKbxvGqDu5T1jHsTzu1smaRFDwuaSJbQ6KSanGKVHzya0gM Q2UM4KBUs1Ykvhs140BzPwpZuVJb70nsDpOZEA78EfU7ZGmZJrr1+YfE1OkzQvGCodMidrmxVnyyA uZXmO3Sxph7KFhGSqHcmNcO5/Pa0st1IuoKCrQzUQvLLjSG4cgR/z9TvET8Tpa/6RiEaIl78uMJPA pDSTyHMQ==; Received: from 108-90-42-56.lightspeed.sntcca.sbcglobal.net ([108.90.42.56] helo=[192.168.1.80]) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCsdF-00EZrR-4u; Wed, 04 Jan 2023 01:31:53 +0000 Message-ID: <53dd3a2c-3f56-dcdc-bb75-5dc5adbe30bf@infradead.org> Date: Tue, 3 Jan 2023 17:31:36 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 0/2] of: Fix handling CONFIG_CMDLINE* even without /chosen node Content-Language: en-US To: Rob Herring , Alexander Sverdlin , Frank Rowand Cc: Linus Walleij , Arnd Bergmann , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230103-dt-cmdline-fix-v1-0-7038e88b18b6@kernel.org> From: Geoff Levand In-Reply-To: <20230103-dt-cmdline-fix-v1-0-7038e88b18b6@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Rob, On 1/3/23 10:00, Rob Herring wrote: > > Let's revert the above commit and redo the missing /chosen node handling > within early_init_dt_scan_chosen(). > > Signed-off-by: Rob Herring > --- > Rob Herring (2): > Revert "of: fdt: Honor CONFIG_CMDLINE* even without /chosen node" > of: fdt: Honor CONFIG_CMDLINE* even without /chosen node, take 2 > > drivers/of/fdt.c | 54 ++++++++++++++++++++++++++++-------------------------- > 1 file changed, 28 insertions(+), 26 deletions(-) I applied these two patches to v6.2-rc2 and tested on PS3. I used a kernel config file that had a CONFIG_CMDLINE, and CONFIG_CMDLINE_FORCE=y set. Everything seemed to work OK. Tested-by: Geoff Levand