devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Agner <stefan@agner.ch>
To: Marcel Ziswiler <marcel@ziswiler.com>, Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Marcel Ziswiler <marcel.ziswiler@toradex.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-tegra-owner@vger.kernel.org
Subject: Re: [PATCH 13/15] ARM: tegra: apalis-tk1: fix pcie switch vendor compatible
Date: Thu, 26 Jul 2018 09:34:49 +0200	[thread overview]
Message-ID: <53e689eca0fe603305642abb559349db@agner.ch> (raw)
In-Reply-To: <20180724104309.21741-14-marcel@ziswiler.com>

On 24.07.2018 12:43, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> 
> PLX got bought by Broadcom therefore fix device tree compatible string
> vendor which silences the following checkpatch.pl warning:
> 
> WARNING: DT compatible string vendor "plx" appears un-documented
>  -- check ./Documentation/devicetree/bindings/vendor-prefixes.txt

This seems to be not the only instance, there are other places where plx
prefix is used. There are 8 instances in total, 4 ARM (in fact all
Toradex device trees) and 4 PowerPC.

One device is already documented in
Documentation/devicetree/bindings/trivial-devices.txt:
plx,pex8648               48-Lane, 12-Port PCI Express Gen 2 (5.0 GT/s)
Switch

I suggest to just add plx as a valid vendor prefix by adding plx to
Documentation/devicetree/bindings/vendor-prefixes.txt:
plx	Broadcom Corporation (formerly PLX Technology)

--
Stefan

> 
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> 
> ---
> 
>  arch/arm/boot/dts/tegra124-apalis-eval.dts      | 2 +-
>  arch/arm/boot/dts/tegra124-apalis-v1.2-eval.dts | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/tegra124-apalis-eval.dts
> b/arch/arm/boot/dts/tegra124-apalis-eval.dts
> index d9805fc97f5e..84ab7dc9febb 100644
> --- a/arch/arm/boot/dts/tegra124-apalis-eval.dts
> +++ b/arch/arm/boot/dts/tegra124-apalis-eval.dts
> @@ -109,7 +109,7 @@
>  		clock-frequency = <400000>;
>  
>  		pcie-switch@58 {
> -			compatible = "plx,pex8605";
> +			compatible = "brcm,pex8605";
>  			reg = <0x58>;
>  		};
>  
> diff --git a/arch/arm/boot/dts/tegra124-apalis-v1.2-eval.dts
> b/arch/arm/boot/dts/tegra124-apalis-v1.2-eval.dts
> index 89783fe76f65..5319f88d3cab 100644
> --- a/arch/arm/boot/dts/tegra124-apalis-v1.2-eval.dts
> +++ b/arch/arm/boot/dts/tegra124-apalis-v1.2-eval.dts
> @@ -74,7 +74,7 @@
>  		clock-frequency = <400000>;
>  
>  		pcie-switch@58 {
> -			compatible = "plx,pex8605";
> +			compatible = "brcm,pex8605";
>  			reg = <0x58>;
>  		};

  reply	other threads:[~2018-07-26  7:34 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-24 10:42 [PATCH 00/15] ARM: dts: tegra: apalis-tk1: major revamp Marcel Ziswiler
2018-07-24 10:42 ` [PATCH 01/15] ARM: tegra: apalis-tk1: add local-mac-address property Marcel Ziswiler
2018-07-24 10:42 ` [PATCH 02/15] ARM: tegra: apalis-tk1: reorder pcie properties Marcel Ziswiler
2018-07-26  7:19   ` Stefan Agner
2018-07-24 10:42 ` [PATCH 03/15] ARM: tegra: apalis-tk1: reorder host1x/hdmi properties Marcel Ziswiler
2018-07-24 10:42 ` [PATCH 04/15] ARM: tegra: apalis-tk1: reorder padctl properties Marcel Ziswiler
2018-07-24 10:42 ` [PATCH 05/15] ARM: tegra: apalis-tk1: regulator clean-up Marcel Ziswiler
2018-07-24 10:43 ` [PATCH 06/15] ARM: tegra: apalis-tk1: add missing regulators Marcel Ziswiler
2018-07-24 10:43 ` [PATCH 07/15] ARM: tegra: apalis-tk1: drop unused pinmux label Marcel Ziswiler
2018-07-24 10:43 ` [PATCH 08/15] ARM: tegra: apalis-tk1: white-space clean-up Marcel Ziswiler
2018-07-24 10:43 ` [PATCH 09/15] ARM: tegra: apalis-tk1: reorder backlight properties Marcel Ziswiler
2018-07-24 10:43 ` [PATCH 10/15] ARM: tegra: apalis-tk1: add proper emmc vmmc and vqmmc supplies Marcel Ziswiler
2018-07-24 10:43 ` [PATCH 11/15] ARM: tegra: apalis-tk1: enable emmc ddr52 mode Marcel Ziswiler
2018-07-24 10:43 ` [PATCH 12/15] ARM: tegra: apalis-tk1: add toradex,apalis-tk1-v1.2 compatible Marcel Ziswiler
2018-07-31 21:45   ` Rob Herring
2018-07-24 10:43 ` [PATCH 13/15] ARM: tegra: apalis-tk1: fix pcie switch vendor compatible Marcel Ziswiler
2018-07-26  7:34   ` Stefan Agner [this message]
2018-07-24 10:43 ` [PATCH 14/15] ARM: tegra: apalis-tk1: reorder cpu dfll clock properties Marcel Ziswiler
2018-07-24 10:43 ` [PATCH 15/15] ARM: tegra: apalis-tk1: reorder SD card properties Marcel Ziswiler
2018-07-24 12:24 ` [PATCH 00/15] ARM: dts: tegra: apalis-tk1: major revamp Marcel Ziswiler
2018-07-24 12:44   ` Dmitry Osipenko
2018-07-24 14:16     ` Marcel Ziswiler
2018-07-24 14:31       ` Dmitry Osipenko
2018-07-24 14:45         ` Marcel Ziswiler
2018-07-24 14:48           ` Dmitry Osipenko
2018-07-24 15:47             ` Peter Geis
2018-07-24 17:03               ` Dmitry Osipenko
2018-07-24 16:23             ` Peter Geis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53e689eca0fe603305642abb559349db@agner.ch \
    --to=stefan@agner.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra-owner@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=marcel.ziswiler@toradex.com \
    --cc=marcel@ziswiler.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).