From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Agner Subject: Re: [PATCH 13/15] ARM: tegra: apalis-tk1: fix pcie switch vendor compatible Date: Thu, 26 Jul 2018 09:34:49 +0200 Message-ID: <53e689eca0fe603305642abb559349db@agner.ch> References: <20180724104309.21741-1-marcel@ziswiler.com> <20180724104309.21741-14-marcel@ziswiler.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180724104309.21741-14-marcel@ziswiler.com> Sender: linux-kernel-owner@vger.kernel.org To: Marcel Ziswiler , Rob Herring Cc: devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, Marcel Ziswiler , Thierry Reding , Jonathan Hunter , Mark Rutland , linux-tegra-owner@vger.kernel.org List-Id: devicetree@vger.kernel.org On 24.07.2018 12:43, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > PLX got bought by Broadcom therefore fix device tree compatible string > vendor which silences the following checkpatch.pl warning: > > WARNING: DT compatible string vendor "plx" appears un-documented > -- check ./Documentation/devicetree/bindings/vendor-prefixes.txt This seems to be not the only instance, there are other places where plx prefix is used. There are 8 instances in total, 4 ARM (in fact all Toradex device trees) and 4 PowerPC. One device is already documented in Documentation/devicetree/bindings/trivial-devices.txt: plx,pex8648 48-Lane, 12-Port PCI Express Gen 2 (5.0 GT/s) Switch I suggest to just add plx as a valid vendor prefix by adding plx to Documentation/devicetree/bindings/vendor-prefixes.txt: plx Broadcom Corporation (formerly PLX Technology) -- Stefan > > Signed-off-by: Marcel Ziswiler > > --- > > arch/arm/boot/dts/tegra124-apalis-eval.dts | 2 +- > arch/arm/boot/dts/tegra124-apalis-v1.2-eval.dts | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/tegra124-apalis-eval.dts > b/arch/arm/boot/dts/tegra124-apalis-eval.dts > index d9805fc97f5e..84ab7dc9febb 100644 > --- a/arch/arm/boot/dts/tegra124-apalis-eval.dts > +++ b/arch/arm/boot/dts/tegra124-apalis-eval.dts > @@ -109,7 +109,7 @@ > clock-frequency = <400000>; > > pcie-switch@58 { > - compatible = "plx,pex8605"; > + compatible = "brcm,pex8605"; > reg = <0x58>; > }; > > diff --git a/arch/arm/boot/dts/tegra124-apalis-v1.2-eval.dts > b/arch/arm/boot/dts/tegra124-apalis-v1.2-eval.dts > index 89783fe76f65..5319f88d3cab 100644 > --- a/arch/arm/boot/dts/tegra124-apalis-v1.2-eval.dts > +++ b/arch/arm/boot/dts/tegra124-apalis-v1.2-eval.dts > @@ -74,7 +74,7 @@ > clock-frequency = <400000>; > > pcie-switch@58 { > - compatible = "plx,pex8605"; > + compatible = "brcm,pex8605"; > reg = <0x58>; > };