Re: [PATCH v2] dt-bindings: clock: qcom,gcc-msm8660: add CE2_P_CLK, PLL4_VOTE + per-clock annotations

[Krzysztof Kozlowski <krzk@kernel.org>]

On 31/05/2026 06:08, Herman van Hazendonk wrote:
> Annotate each clock with provenance and consumer information cross-
> referenced against the GCC driver, the downstream HTC/Samsung/Palm
> sources and the legacy TouchPad / Pre3 vendor trees, so reviewers
> adding new MSM8x60 board DTs can tell at a glance whether a given
> clock is wired up in the GCC driver, in the device tree, or both.

I don't understand what problem you are solving. ABI is fixed, you
cannot change it. This document does not describe usage, but ABI with
clock IDs.

I suggest to start commit msg with clear description of existing problem.

> 
> Add two clocks that the in-tree driver and downstream consumers
> already use but which were missing from the header:
> 
>   - CE2_P_CLK (Crypto Engine 2 APB) - needed by drivers/crypto/qce
>     for the MSM8x60 CE2 path that the qcom,msm8660-qce binding adds.
>   - PLL4_VOTE - software-vote handle for the LPASS PLL4 used by both
>     lcc-msm8660 and the modem subsystem.

Don't mix up completely independent work.

Best regards,
Krzysztof