From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6C01C7EE2A for ; Tue, 9 May 2023 22:31:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235593AbjEIWbV (ORCPT ); Tue, 9 May 2023 18:31:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230264AbjEIWbU (ORCPT ); Tue, 9 May 2023 18:31:20 -0400 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D6B726B3 for ; Tue, 9 May 2023 15:31:18 -0700 (PDT) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-3f450815d02so2364265e9.0 for ; Tue, 09 May 2023 15:31:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683671476; x=1686263476; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=H+e/daKX9drvWfcCFRUKynPMFbFB2xNv5pizYcQC/Ps=; b=GFKH2bIxWke50r1pk7SF3vM1y+2UUkocKOj6AaVv+BIbIfPb50J4niBeH1qWBCHgYn pMhPqIqQDEDD+sPbCSttytseujK0mOooNf2ruJHaG29ec55LjHb0G2J+HEq5FzmvvBp0 36d7RVt4jcPGXnfNoReBUhTuSBiVFtHWQ5yoGoRTRce32Mfu9+o1ydhhQHD8tlLMkmK3 4CO3f3u0TLd1Eke1T5U/18ADKLGOZowqrg8mCMirvnC+NslO3BpmNQVi7rNa4vAHzXJ2 0rrUakHbjlgSUan4I1Om8PTRhYDXNkfSDTSScef8xYGdK9XcxQrVhfmrxBdG9Js19fVk Ozkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683671476; x=1686263476; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=H+e/daKX9drvWfcCFRUKynPMFbFB2xNv5pizYcQC/Ps=; b=D1T44oTCg3a7oQbc0/yTSpqmS+pZjDcfSHWjd2bMtdioxa0T3sf6+m2OADGrmiJEHq iNoHJsMuq9tluzYZHMC9Dl2aexlGEI1j/Sm8qqal88PMszaS82H2YVBUuzZ3MO7EPXZw uov9Q2CRfdpTngCrBAjwgaH1F6290P5CXnPHdS179xJkNsnM6K5AMW3rvL0w2ldbi7sV UY7BwfQ608kpCUdAJkEgZlY0xceKa89rXR6F+YYOZm7Pt50DZth2U9m/7ucDPFYpMGfL dIfXbJJZOQ0JNz3dMn5gT16qhDt3GFU5hpr2HtQRWuLL3ujby/BTDQ8t8ipD7wQesTbB m7qA== X-Gm-Message-State: AC+VfDzJplbKlEuCsRGJEAUOKRfj1xyaAQwBU3HdxlHxMYcZRZwKEuBM h7kxqeKMQsg78puJc/8OeEdDuA== X-Google-Smtp-Source: ACHHUZ6si+b8+Ej7zsK3mGDrXpwwIIjfiDltVqOh0t/imBMJJulNtoJoVip+zo8oVrlJXojtlzg4yg== X-Received: by 2002:a05:600c:29a:b0:3f4:2973:b8c8 with SMTP id 26-20020a05600c029a00b003f42973b8c8mr3730808wmk.26.1683671476656; Tue, 09 May 2023 15:31:16 -0700 (PDT) Received: from [192.168.0.15] (cpc76484-cwma10-2-0-cust274.7-3.cable.virginm.net. [82.31.201.19]) by smtp.gmail.com with ESMTPSA id z10-20020a05600c220a00b003f17122587bsm21203561wml.36.2023.05.09.15.31.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 May 2023 15:31:16 -0700 (PDT) Message-ID: <53f6e9c7-26e2-94be-fa02-0c3cbb65372b@linaro.org> Date: Tue, 9 May 2023 23:31:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 1/6] soc: qcom: ocmem: Fix NUM_PORTS & NUM_MACROS macros Content-Language: en-US To: Luca Weiss , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Clark , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20230506-msm8226-ocmem-v1-0-3e24e2724f01@z3ntu.xyz> <20230506-msm8226-ocmem-v1-1-3e24e2724f01@z3ntu.xyz> From: Caleb Connolly In-Reply-To: <20230506-msm8226-ocmem-v1-1-3e24e2724f01@z3ntu.xyz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 07/05/2023 10:12, Luca Weiss wrote: > Since we're using these two macros to read a value from a register, we > need to use the FIELD_GET instead of the FIELD_PREP macro, otherwise > we're getting wrong values. > > So instead of: > > [ 3.111779] ocmem fdd00000.sram: 2 ports, 1 regions, 512 macros, not interleaved > > we now get the correct value of: > > [ 3.129672] ocmem fdd00000.sram: 2 ports, 1 regions, 2 macros, not interleaved > > Fixes: 88c1e9404f1d ("soc: qcom: add OCMEM driver") > Signed-off-by: Luca Weiss Reviewed-by: Caleb Connolly > --- > drivers/soc/qcom/ocmem.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/soc/qcom/ocmem.c b/drivers/soc/qcom/ocmem.c > index 199fe9872035..c3e78411c637 100644 > --- a/drivers/soc/qcom/ocmem.c > +++ b/drivers/soc/qcom/ocmem.c > @@ -76,8 +76,8 @@ struct ocmem { > #define OCMEM_REG_GFX_MPU_START 0x00001004 > #define OCMEM_REG_GFX_MPU_END 0x00001008 > > -#define OCMEM_HW_PROFILE_NUM_PORTS(val) FIELD_PREP(0x0000000f, (val)) > -#define OCMEM_HW_PROFILE_NUM_MACROS(val) FIELD_PREP(0x00003f00, (val)) > +#define OCMEM_HW_PROFILE_NUM_PORTS(val) FIELD_GET(0x0000000f, (val)) > +#define OCMEM_HW_PROFILE_NUM_MACROS(val) FIELD_GET(0x00003f00, (val)) > > #define OCMEM_HW_PROFILE_LAST_REGN_HALFSIZE 0x00010000 > #define OCMEM_HW_PROFILE_INTERLEAVING 0x00020000 > -- Kind Regards, Caleb (they/them)