From: Huang Tao <huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
To: "edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
赵仪峰 <zyf-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Cc: HeikoStübner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
"Arnd Bergmann" <arnd-r2nGTMty4D4@public.gmane.org>,
"Caesar Wang"
<caesar.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
"rui.zhang" <rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"grant.likely"
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
robh+dt <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-pm <linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-arm-kernel
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-doc <linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
蔡枫 <cf-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
dianders <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
dtor <dtor-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
钟勇汪 <zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
"addy.ke-TNX95d0MmH7DzftRWevZcw@public.gmane.org"
<addy.ke-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
"dmitry.torokhov"
<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-iio <linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Jonathan Cameron"
<jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v3 1/4] thermal: rockchip: add driver for thermal
Date: Fri, 29 Aug 2014 20:08:44 +0800 [thread overview]
Message-ID: <54006D4C.2070404@rock-chips.com> (raw)
In-Reply-To: <CAC-25o-winy6jVjh9_hQ-t2VO2UfxG67pW5DpOve8A2o39EJSw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Dear Eduardo Bezerra Valentin:
在 2014年08月29日 19:39, edubezval-Re5JQEeQqe8@public.gmane.orgm 写道:
> Hello Zhao,
>
> On Thu, Aug 28, 2014 at 9:54 PM, 赵仪峰 <zyf@rock-chips.com> wrote:
>> Hi Heiko,
>>
>> The TS-ADC on RK3288 has two component, a tsadc and a tsadc controller.
>> The tsadc controller is similar like the thermal manager unit on other SOCs.
>> We followed the naming of 3066, but not named as the Thermal Manager.
>>
>> Moreover,there is only one set of apb registers to access the tsadc
>> controller,and the tsadc is controlled by the tsadc controller,could not
>> access directly. If we write a general tsadc driver by accessed tsadc
>> controller registers, and it hardly to write a driver for the tsadc
>> controller.
> As suggested by Arnd, you can use the generic driver as interface
> between thermal framework and IIO layer. The driver you are going to
> write to your ADC is going to be in the IIO subsystem. The only
> difference is that the generic driver would work for any ADC driver in
> the IIO subsystem.
> https://lkml.org/lkml/2014/2/5/810
>
> In fact, there is already a generic driver. We just need to get it up
> to date. I see some testing has been already done, and results sound
> promising.
This iio_thermal driver only support get temperature from the ADC IIO
channel.
It dose not support any advanced feature such as configure the
temperature when system should be reset.
So if we adapt it, we will access the register form both TSADC IIO
driver and thermal driver.
I don't thank this is a good ideal.
In fact, we should ignore the "ADC" stuff. This sensor use ADC internal,
but it is transparent to software, especially in automatic mode.
>
>> So, I do not agree to write a generic adc driver for the rk3288-tsadc.
>>
>> ________________________________
>> Yifeng Zhao
>>
>>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-08-29 12:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 0:59 [PATCH v3 0/4] Rockchip soc theamal driver Caesar Wang
2014-08-28 0:59 ` [PATCH v3 1/4] thermal: rockchip: add driver for thermal Caesar Wang
2014-08-28 8:48 ` Arnd Bergmann
2014-08-28 14:37 ` Eduardo Valentin
2014-08-28 16:11 ` Heiko Stübner
2014-08-28 16:16 ` Arnd Bergmann
2014-08-28 19:36 ` Caesar Wang
2014-08-28 23:01 ` Heiko Stübner
2014-08-29 1:54 ` 赵仪峰
2014-08-29 11:39 ` edubezval
[not found] ` <CAC-25o-winy6jVjh9_hQ-t2VO2UfxG67pW5DpOve8A2o39EJSw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-08-29 12:08 ` Huang Tao [this message]
2014-08-30 9:30 ` Jonathan Cameron
2014-08-28 0:59 ` [PATCH v3 2/4] dt-bindings: document Rockchip thermal Caesar Wang
2014-08-28 0:59 ` [PATCH v3 3/4] ARM: dts: add main Thermal info to rk3288 Caesar Wang
2014-08-28 0:59 ` [PATCH v4 4/4] ARM: dts: enable Thermal on rk3288-evb board Caesar Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54006D4C.2070404@rock-chips.com \
--to=huangtao-tnx95d0mmh7dzftrwevzcw@public.gmane.org \
--cc=addy.ke-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=caesar.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
--cc=cf-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=dtor-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=zyf-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
--cc=zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).