From: Stephen Boyd <sboyd@codeaurora.org>
To: Courtney Cavin <courtney.cavin@sonymobile.com>,
Bjorn Andersson <bjorn.andersson@sonymobile.com>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
Kumar Gala <galak@codeaurora.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Grant Likely <grant.likely@linaro.org>,
Suman Anna <s-anna@ti.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
Jeffrey Hugo <jhugo@codeaurora.org>,
Eric Holmberg <eholmber@codeaurora.org>
Subject: Re: [PATCH v2] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block
Date: Fri, 29 Aug 2014 17:14:07 -0700 [thread overview]
Message-ID: <5401174F.8040508@codeaurora.org> (raw)
In-Reply-To: <20140829234128.GB25668@sonymobile.com>
On 08/29/14 16:41, Courtney Cavin wrote:
> On Sat, Aug 30, 2014 at 01:14:23AM +0200, Bjorn Andersson wrote:
>> From: Kumar Gala <galak@codeaurora.org>
>>
>> Add driver for Qualcomm MSM Hardware Mutex block that exists on
>> newer Qualcomm SoCs.
>>
>> Cc: Jeffrey Hugo <jhugo@codeaurora.org>
>> Cc: Eric Holmberg <eholmber@codeaurora.org>
>> Cc: Courtney Cavin <courtney.cavin@sonymobile.com>
>> Signed-off-by: Kumar Gala <galak@codeaurora.org>
>> [bjorn: added pm_runtime calls, from Courtney,
>> added sfpb-mutex compatible,
>> updated DT binding documentation formatting]
>> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
>> ---
> [...]
>> diff --git a/drivers/hwspinlock/Kconfig b/drivers/hwspinlock/Kconfig
>> index 3612cb5..2cd39e2 100644
>> --- a/drivers/hwspinlock/Kconfig
>> +++ b/drivers/hwspinlock/Kconfig
>> @@ -8,6 +8,17 @@ config HWSPINLOCK
>>
>> menu "Hardware Spinlock drivers"
>>
>> +config HWSPINLOCK_MSM
>> + tristate "MSM Hardware Spinlock device"
>> + depends on ARCH_QCOM
> This should also depend on OF, as it won't compile or work without it.
Doesn't ARCH_QCOM imply OF? ARCH_MULTIPLATFORM has a select USE_OF.
>
>> + select HWSPINLOCK
>> + help
>> + Say y here to support the MSM Hardware Mutex functionality, which
>> + provides a synchronisation mechanism for the various processors on
>> + the SoC.
>> +
>> + If unsure, say N.
>> +
>>
Maybe MSM should be changed to qcom? Just a thought.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-08-30 0:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 23:14 [PATCH v2] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block Bjorn Andersson
2014-08-29 23:41 ` Courtney Cavin
2014-08-30 0:14 ` Stephen Boyd [this message]
2014-08-30 0:47 ` Courtney Cavin
2014-09-02 17:28 ` Jeffrey Hugo
2014-09-02 18:48 ` Bjorn Andersson
-- strict thread matches above, loose matches on Subject: below --
2013-07-29 22:00 Kumar Gala
2013-08-12 16:35 ` Stephen Boyd
2013-08-13 15:54 ` Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5401174F.8040508@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=bjorn.andersson@sonymobile.com \
--cc=courtney.cavin@sonymobile.com \
--cc=devicetree@vger.kernel.org \
--cc=eholmber@codeaurora.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ohad@wizery.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=s-anna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).