From mboxrd@z Thu Jan  1 00:00:00 1970
From: Varka Bhadram <varkabhadram@gmail.com>
Subject: Re: [PATCH v4 1/2] rc: Add DT bindings for hix5hd2
Date: Mon, 01 Sep 2014 09:19:03 +0530
Message-ID: <5403ECAF.1040506@gmail.com>
References: <1409452751-17463-1-git-send-email-zhangfei.gao@linaro.org> <1409452751-17463-2-git-send-email-zhangfei.gao@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-media-owner@vger.kernel.org>
In-Reply-To: <1409452751-17463-2-git-send-email-zhangfei.gao@linaro.org>
Sender: linux-media-owner@vger.kernel.org
To: Zhangfei Gao <zhangfei.gao@linaro.org>, Mauro Carvalho Chehab <m.chehab@samsung.com>, sean@mess.org, arnd@arndb.de, haifeng.yan@linaro.org, jchxue@gmail.com
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-media@vger.kernel.org, Guoxiong Yan <yanguoxiong@huawei.com>
List-Id: devicetree@vger.kernel.org

On 08/31/2014 08:09 AM, Zhangfei Gao wrote:
> From: Guoxiong Yan <yanguoxiong@huawei.com>
>
> Signed-off-by: Guoxiong Yan <yanguoxiong@huawei.com>
> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> ---
>   .../devicetree/bindings/media/hix5hd2-ir.txt       |   25 ++++++++++++++++++++
>   1 file changed, 25 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/media/hix5hd2-ir.txt
>
> diff --git a/Documentation/devicetree/bindings/media/hix5hd2-ir.txt b/Documentation/devicetree/bindings/media/hix5hd2-ir.txt
> new file mode 100644
> index 0000000..fb5e760
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/hix5hd2-ir.txt
> @@ -0,0 +1,25 @@
> +Device-Tree bindings for hix5hd2 ir IP
> +
> +Required properties:
> +	- compatible: Should contain "hisilicon,hix5hd2-ir".
> +	- reg: Base physical address of the controller and length of memory
> +	  mapped region.
> +	- interrupts: interrupt-specifier for the sole interrupt generated by
> +	  the device. The interrupt specifier format depends on the interrupt
> +	  controller parent.
> +	- clocks: clock phandle and specifier pair.
> +	- hisilicon,power-syscon: phandle of syscon used to control power.
> +

No need of tab space before -compatible.... Give tab spaces after properties...

ex:
  
Required properties:
- compatible		: Should contain "hisilicon,hix5hd2-ir".
- reg			: Base physical address of the controller and length of memory
			  mapped region.

...

Its not standard, but in my view it is understandable. Now every one following this
one.

Thanks..

> +Optional properties:
> +	- linux,rc-map-name : Remote control map name.
> +
> +Example node:
> +
> +	ir: ir@f8001000 {
> +		compatible = "hisilicon,hix5hd2-ir";
> +		reg = <0xf8001000 0x1000>;
> +		interrupts = <0 47 4>;
> +		clocks = <&clock HIX5HD2_FIXED_24M>;
> +		hisilicon,power-syscon = <&sysctrl>;
> +		linux,rc-map-name = "rc-tivo";
> +	};


-- 
Regards,
Varka Bhadram.