Re: [PATCH v4 1/2] rc: Add DT bindings for hix5hd2

[zhangfei <zhangfei.gao@linaro.org>]

On 09/01/2014 11:49 AM, Varka Bhadram wrote:
> On 08/31/2014 08:09 AM, Zhangfei Gao wrote:
>> From: Guoxiong Yan <yanguoxiong@huawei.com>
>>
>> Signed-off-by: Guoxiong Yan <yanguoxiong@huawei.com>
>> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
>> ---
>>   .../devicetree/bindings/media/hix5hd2-ir.txt       |   25
>> ++++++++++++++++++++
>>   1 file changed, 25 insertions(+)
>>   create mode 100644
>> Documentation/devicetree/bindings/media/hix5hd2-ir.txt
>>
>> diff --git a/Documentation/devicetree/bindings/media/hix5hd2-ir.txt
>> b/Documentation/devicetree/bindings/media/hix5hd2-ir.txt
>> new file mode 100644
>> index 0000000..fb5e760
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/hix5hd2-ir.txt
>> @@ -0,0 +1,25 @@
>> +Device-Tree bindings for hix5hd2 ir IP
>> +
>> +Required properties:
>> +    - compatible: Should contain "hisilicon,hix5hd2-ir".
>> +    - reg: Base physical address of the controller and length of memory
>> +      mapped region.
>> +    - interrupts: interrupt-specifier for the sole interrupt
>> generated by
>> +      the device. The interrupt specifier format depends on the
>> interrupt
>> +      controller parent.
>> +    - clocks: clock phandle and specifier pair.
>> +    - hisilicon,power-syscon: phandle of syscon used to control power.
>> +
>
> No need of tab space before -compatible.... Give tab spaces after
> properties...
>
> ex:
>
> Required properties:
> - compatible        : Should contain "hisilicon,hix5hd2-ir".
> - reg            : Base physical address of the controller and length of
> memory
>                mapped region.
>
> ...
>
> Its not standard, but in my view it is understandable. Now every one
> following this
> one.

Really, I still prefer the original one.
Have checked several bindings under media, so add tab ahead
like st-rc.txt, gpio-ir-receiver.txt

Thanks