devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Caesar Wang <caesar.wang@rock-chips.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: heiko@sntech.de, rui.zhang@intel.com, edubezval@gmail.com,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-doc@vger.kernel.org, huangtao@rock-chips.com,
	cf@rock-chips.com, dianders@chromium.org, zyw@rock-chips.com,
	addy.ke@rock-chips.com, zhaoyifeng <zyf@rock-chips.com>
Subject: Re: [PATCH v4 1/4] thermal: rockchip: add driver for thermal
Date: Fri, 05 Sep 2014 08:33:23 +0800	[thread overview]
Message-ID: <540904D3.1070004@rock-chips.com> (raw)
In-Reply-To: <20140904170559.GB10224@core.coreip.homeip.net>


在 2014年09月05日 01:06, Dmitry Torokhov 写道:
> Hi Caesar,
>
> On Wed, Sep 03, 2014 at 10:10:36AM +0800, Caesar Wang wrote:
>> +static int rockchip_thermal_remove(struct platform_device *pdev)
>> +{
>> +	struct rockchip_thermal_data *data = platform_get_drvdata(pdev);
>> +
>> +	rockchip_thermal_control(data, false);
>> +
>> +	thermal_zone_device_unregister(data->tz);
>> +	cpufreq_cooling_unregister(data->cdev);
>> +	cpufreq_cooling_unregister(data->cdev);
> It looks like we are unregistering the same cooling device one too many times.
>
> Thanks.
>
yes,I made a stupid mistake.  Thanks~

-- 
Best regards,
Caesar



  reply	other threads:[~2014-09-05  0:33 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-03  2:10 [PATCH v4 0/4] Rockchip soc thermal driver Caesar Wang
2014-09-03  2:10 ` [PATCH v4 1/4] thermal: rockchip: add driver for thermal Caesar Wang
2014-08-30 20:09   ` Eduardo Valentin
2014-09-10  4:39     ` Caesar Wang
2014-09-10 12:46       ` Eduardo Valentin
2014-09-10 13:21         ` Caesar Wang
2014-09-17  7:29         ` Caesar Wang
2014-09-04 17:06   ` Dmitry Torokhov
2014-09-05  0:33     ` Caesar Wang [this message]
2014-09-03  2:10 ` [PATCH v4 2/4] dt-bindings: document Rockchip thermal Caesar Wang
2014-09-03  8:07   ` Heiko Stübner
2014-09-04  1:02     ` Caesar Wang
2014-09-09  2:27       ` Zhang Rui
2014-09-09 11:35         ` Heiko Stübner
2014-09-09 15:09           ` Eduardo Valentin
2014-09-10  1:02             ` Zhang Rui
2014-09-10  1:14               ` edubezval
2014-09-10  7:24                 ` Heiko Stübner
2014-09-11  2:36                   ` Zhang Rui
2014-09-11 12:18                     ` Eduardo Valentin
2014-09-11 12:32                       ` Arnd Bergmann
2014-09-11 15:53                         ` Eduardo Valentin
2014-09-16  7:23                           ` Zhang Rui
2014-09-16  7:45                           ` Zhang Rui
2014-09-03  2:10 ` [PATCH v4 3/4] ARM: dts: add main Thermal info to rk3288 Caesar Wang
2014-09-09 11:37   ` Heiko Stübner
2014-09-10  2:49     ` Caesar Wang
2014-09-11 13:58       ` Heiko Stübner
2014-09-03  2:10 ` [PATCH v4 4/4] ARM: dts: enable Thermal on rk3288-evb board Caesar Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=540904D3.1070004@rock-chips.com \
    --to=caesar.wang@rock-chips.com \
    --cc=addy.ke@rock-chips.com \
    --cc=cf@rock-chips.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=edubezval@gmail.com \
    --cc=heiko@sntech.de \
    --cc=huangtao@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=zyf@rock-chips.com \
    --cc=zyw@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).