From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FC8C18FDAB; Tue, 20 Aug 2024 15:37:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724168271; cv=none; b=lPmuTxVcbQ2wu9fvw0MdEVeI5ZkwgoWeW2YrkNGyvTu8jMssNMcJQSXTL3emZuoIR+WE1Gz6yQ/NgYdxSy9xsl70k7S8ewA5PHU7ENsf0jvcn4+1EclIrs8hP0dpTZyJXWktsGI0VgUpv2Ogp6zJrOr/mXHKjkiWaFCG2sj0xsI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724168271; c=relaxed/simple; bh=jgzfSxzkcr1kPvx0POPuK1VETbq4yBhdnx2BodVkoAo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=U8CQljzEKWVv2ViGYGYepSGSmWuCzm1kZAE+S01KN+Y3V6YftrmmaKROo1UFHvG/yMHDWSE4Nd9cXlDjVLOiPDNvHvoSrwomN4diiQ40o/v3AuX2IoFwt2wMdmSDcs1MZ4KjFstjwiFOfuMysVtRQd2BXPAMv0rSWAF/PAfcG1s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QFwbw2h6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QFwbw2h6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28F6CC4AF0B; Tue, 20 Aug 2024 15:37:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724168270; bh=jgzfSxzkcr1kPvx0POPuK1VETbq4yBhdnx2BodVkoAo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=QFwbw2h6tpnuYNijlrvUQAHd889c5/rE4aKj1+vX+HgPRDzq14XoyKH8YGQdnevRj Bp2dUEV3SR99DpZrN/aMrY6xNHT2S8b175QlfCqlJ6QxLA4OvSMYC4CqWsoxWwfQCb hkDi2wu38kRdmA3mKmLBsxV/zbalI2ML9ehtdA+i0oCWh8WzbUwv07NEM5CLovPJ2u VwWZJGit9Nug1Moq2SjkMfY8ns5IjCxqIkbqKoH/i1tVUldiKyv0RyPaYI2cPzFfS1 5Sp3i0aL0Tf/k6/4Ji+/EdO2lFJE+uySiFWxuPYA3jeHtSoY1LqHDCF/Scid4maliy PXnl4wt6zIB0w== Message-ID: <5410a790-52fc-45ab-825a-ccc3f758915d@kernel.org> Date: Tue, 20 Aug 2024 17:37:46 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: wireless: restore constraint for brcm,bcm4329-fmac compatible property To: Arend Van Spriel Cc: Kalle Valo , Hector Martin , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, asahi@lists.linux.dev References: <20240820101216.355012-1-arend.vanspriel@broadcom.com> <20240820101216.355012-2-arend.vanspriel@broadcom.com> <7881c303-bef1-403a-aa70-30d33558f57f@kernel.org> <6777d425-b27f-43d0-ba81-b36ac0b8f929@broadcom.com> <19170474e58.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <19170474e58.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 20/08/2024 16:53, Arend Van Spriel wrote: > On August 20, 2024 2:50:24 PM Arend van Spriel > wrote: > >> On 8/20/2024 1:39 PM, Krzysztof Kozlowski wrote: >>> On 20/08/2024 13:27, Krzysztof Kozlowski wrote: >>>> On Tue, Aug 20, 2024 at 12:12:15PM +0200, Arend van Spriel wrote: >>>>> When extending the bindings for Apple PCIe devices the compatible property >>>>> specification was changed. However, it was changed such that for these >>>>> devices it was no longer necessary to have "brcm,bcm4329-fmac" listed as >>>>> string in the compatible list property as it was before that extension. >>>> >>>> Apart that this was never tested... That statement is not true. Look at >>>> "fixed" commit - it is not doing like that at all. >>>> >>>> I don't understand the reasoning. >>>> >>>>> This patch restores that constraint. >>>>> >>>>> Fixes: e2e37224e8b3 ("dt-bindings: net: bcm4329-fmac: Add Apple properties >>>>> & chips") >>>>> Signed-off-by: Arend van Spriel >>>>> --- >>>>> .../net/wireless/brcm,bcm4329-fmac.yaml | 19 ++++++++++--------- >>>>> 1 file changed, 10 insertions(+), 9 deletions(-) >>>>> >>>>> diff --git >>>>> a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml >>>>> b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml >>>>> index e564f20d8f41..47f90446322f 100644 >>>>> --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml >>>>> +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml >>>>> @@ -7,7 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# >>>>> title: Broadcom BCM4329 family fullmac wireless SDIO/PCIE devices >>>>> >>>>> maintainers: >>>>> - - Arend van Spriel >>>>> + - Arend van Spriel >>>>> >>>>> description: >>>>> The Broadcom Single chip MAC part for the BCM4329 family and >>>>> @@ -27,7 +27,6 @@ properties: >>>>> - brcm,bcm4341b0-fmac >>>>> - brcm,bcm4341b4-fmac >>>>> - brcm,bcm4341b5-fmac >>>>> - - brcm,bcm4329-fmac >>>>> - brcm,bcm4330-fmac >>>>> - brcm,bcm4334-fmac >>>>> - brcm,bcm43340-fmac >>>>> @@ -46,13 +45,15 @@ properties: >>>>> - cypress,cyw43012-fmac >>>>> - infineon,cyw43439-fmac >>>>> - const: brcm,bcm4329-fmac >>>>> - - enum: >>>>> - - brcm,bcm4329-fmac >>>>> - - pci14e4,43dc # BCM4355 >>>>> - - pci14e4,4464 # BCM4364 >>>>> - - pci14e4,4488 # BCM4377 >>>>> - - pci14e4,4425 # BCM4378 >>>>> - - pci14e4,4433 # BCM4387 >>>>> + - items: >>>>> + - enum: >>>>> + - pci14e4,43dc # BCM4355 >>>>> + - pci14e4,4464 # BCM4364 >>>>> + - pci14e4,4488 # BCM4377 >>>>> + - pci14e4,4425 # BCM4378 >>>>> + - pci14e4,4433 # BCM4387 >>>>> + - const: brcm,bcm4329-fmac >>>>> + - const: brcm,bcm4329-fmac >>>> >>>> And this does not make sense... You claim that some constrained was >>>> droppped and you re-add it, but in fact you still add the same code as >>>> it was before. >>>> >>>> NAK. >>> >>> Ah, the last "const" actually makes sense, I missed that. >>> >>> Commit still however lacks rationale why these devices are compatible. >>> Plus existing rationale that e2e37224e8b3 changed something is entirely >>> WRONG. It changed nothing. ZERO. It only added new devices, which was >>> claimed are not compatible with brcm,bcm4329-fmac. >> >> So is that claim true? What does it mean that these new devices are not >> compatible. If they are they should be in a separate binding or the >> applicable properties for these devices should be made conditional. >> >>> Now if you claim that original commit which said "these devices are not >>> compatible with brcm,bcm4329-fmac", then please provide arguments, not >>> just say "other commit did something". It did nothing... >> >> Not entirely true. Indeed new devices were added for which no >> "brcm,bcm4329-fmac" string is required in the compatible property. Also >> the commit added new properties for these new devices. Now in my opinion >> a driver should not use these properties without a "compatible" check. >> Hope we can agree to that. However, the driver patch for supporting the >> binding change does no such thing. So if we leave the binding as it >> currently is the driver will have to check if compatible has any of the >> listed PCI IDs before processing the properties. As all properties old >> and new are marked as optional I can not come up with an argument that >> these new devices are *not* compatible with brcm,bcm4329-fmac. > > Looking at the commit in patchwork I see no claim in the commit message > that the new devices are not compatible. The patch even adds enum with the > PCI IDs *and* brcm,bcm4329-fmac. It is anyone's guess what the intent was Enum means not compatible. What to add more? You use one fact to deliver entirely different conclusion. > for doing that. My take is that this was a mistake worth fixing. > You still did not describe any mistake here. Best regards, Krzysztof