From: Nathan Lynch <Nathan_Lynch@mentor.com>
To: Christopher Covington <cov@codeaurora.org>
Cc: Doug Anderson <dianders@chromium.org>,
olof@lixom.net, mark.rutland@arm.com, devicetree@vger.kernel.org,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
pawel.moll@arm.com, ijc+devicetree@hellion.org.uk,
Marc Zyngier <marc.zyngier@arm.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Sudeep Holla <Sudeep.Holla@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
Catalin Marinas <Catalin.Marinas@arm.com>,
galak@codeaurora.org, Thomas Gleixner <tglx@linutronix.de>,
Sonny Rao <sonnyrao@chromium.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clocksource: arch_timer: Allow the device tree to specify the physical timer
Date: Thu, 11 Sep 2014 11:07:34 -0500 [thread overview]
Message-ID: <5411C8C6.4060509@mentor.com> (raw)
In-Reply-To: <5411C68B.6090308@codeaurora.org>
On 09/11/2014 10:58 AM, Christopher Covington wrote:
>
> On 09/11/2014 11:52 AM, Doug Anderson wrote:
>> diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
>> index 5163ec1..8ca07a9 100644
>> --- a/drivers/clocksource/arm_arch_timer.c
>> +++ b/drivers/clocksource/arm_arch_timer.c
>> @@ -649,6 +649,9 @@ static void __init arch_timer_init(struct device_node *np)
>> arch_timer_ppi[i] = irq_of_parse_and_map(np, i);
>> arch_timer_detect_rate(NULL, np);
>>
>> + if (of_property_read_bool(np, "arm,use-physical-timer"))
>> + arch_timer_use_virtual = false;
>> +
>> /*
>> * If HYP mode is available, we know that the physical timer
>> * has been configured to be accessible from PL1. Use it, so
>>
>
> How's the VDSO supposed to deal with this? It currently does:
>
> cycle_now = arch_counter_get_cntvct()
Note the VDSO for 32-bit ARM is still out of tree so there's no mainline
regression in that respect.
I think as long as there's some way for the vdso initialization code to
discover that it can't use the virtual counter, it should be tractable.
If that involves adding an API to the arch timer code, that can be
added along with the vdso code.
prev parent reply other threads:[~2014-09-11 16:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 15:52 [PATCH] clocksource: arch_timer: Allow the device tree to specify the physical timer Doug Anderson
2014-09-11 15:58 ` Christopher Covington
2014-09-11 16:04 ` Doug Anderson
2014-09-11 16:09 ` Will Deacon
2014-09-11 16:20 ` Christopher Covington
2014-09-11 16:07 ` Nathan Lynch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5411C8C6.4060509@mentor.com \
--to=nathan_lynch@mentor.com \
--cc=Catalin.Marinas@arm.com \
--cc=Sudeep.Holla@arm.com \
--cc=cov@codeaurora.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=sonnyrao@chromium.org \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).