From: Marc Zyngier <marc.zyngier@arm.com>
To: Will Deacon <will.deacon@arm.com>
Cc: Doug Anderson <dianders@chromium.org>,
"olof@lixom.net" <olof@lixom.net>,
Sonny Rao <sonnyrao@chromium.org>,
Catalin Marinas <Catalin.Marinas@arm.com>,
Mark Rutland <Mark.Rutland@arm.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Sudeep Holla <Sudeep.Holla@arm.com>,
Christopher Covington <cov@codeaurora.org>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Nathan Lynch <Nathan_Lynch@mentor.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
Pawel Moll <Pawel.Moll@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] clocksource: arch_timer: Allow the device tree to specify the physical timer
Date: Thu, 11 Sep 2014 18:00:24 +0100 [thread overview]
Message-ID: <5411D528.4050605@arm.com> (raw)
In-Reply-To: <20140911164710.GW6158@arm.com>
On 11/09/14 17:47, Will Deacon wrote:
> On Thu, Sep 11, 2014 at 05:16:44PM +0100, Doug Anderson wrote:
>> Some 32-bit (ARMv7) systems are architected like this:
>>
>> * The firmware doesn't know and doesn't care about hypervisor mode and
>> we don't want to add the complexity of hypervisor there.
>>
>> * The firmware isn't involved in SMP bringup or resume.
>>
>> * The ARCH timer come up with an uninitialized offset between the
>> virtual and physical counters. Each core gets a different random
>> offset.
>>
>> On systems like the above, it doesn't make sense to use the virtual
>> counter. There's nobody managing the offset and each time a core goes
>> down and comes back up it will get reinitialized to some other random
>> value.
>
> You probably need to rephrase this slightly, as there *is* still a
> requirement on the hypervisor/firmware (actually, two!). See below.
>
>> Let's add a property to the device tree to say that we shouldn't use
>> the virtual timer. Firmware could potentially remove this property
>> before passing the device tree to the kernel if it really wants the
>> kernel to use a virtual timer.
>>
>> Note that it's been said that ARM64 (ARMv8) systems the firmware and
>> kernel really can't be architected as described above. That means
>> using the physical timer like this really only makes sense for ARMv7
>> systems.
>
> I'd go further: this only makes sense if you're booting in secure SVC
> mode.
If that's the case, what's the problem? Enter monitor mode, set SCR.NS
to one, nuke CNTVOFF, revert, job done.
What am I missing?
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2014-09-11 17:00 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 16:16 [PATCH v2] clocksource: arch_timer: Allow the device tree to specify the physical timer Doug Anderson
[not found] ` <1410452204-7277-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-09-11 16:47 ` Will Deacon
[not found] ` <20140911164710.GW6158-5wv7dgnIgG8@public.gmane.org>
2014-09-11 16:59 ` Doug Anderson
2014-09-11 17:07 ` Will Deacon
2014-09-11 17:14 ` Doug Anderson
2014-09-11 17:00 ` Marc Zyngier [this message]
[not found] ` <5411D528.4050605-5wv7dgnIgG8@public.gmane.org>
2014-09-11 17:11 ` Doug Anderson
[not found] ` <CAD=FV=XMmizxJFPj0FEhJ7Gk4ZcQaUJDxf_Qq5kGKSvxDFVmzg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-11 17:22 ` Marc Zyngier
[not found] ` <5411DA67.2040402-5wv7dgnIgG8@public.gmane.org>
2014-09-11 17:29 ` Doug Anderson
[not found] ` <CAD=FV=UQfo4J3P4wGjOhQZQ5KXKgYAdjPsi1ykKZxQw-FwJz8w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-11 17:43 ` Marc Zyngier
[not found] ` <5411DF5D.8060906-5wv7dgnIgG8@public.gmane.org>
2014-09-11 23:55 ` Doug Anderson
2014-09-11 23:56 ` Stephen Boyd
[not found] ` <54123697.4070804-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-09-12 0:01 ` Doug Anderson
2014-09-12 10:20 ` Marc Zyngier
2014-09-12 0:14 ` Sonny Rao
2014-09-12 1:17 ` Stephen Boyd
2014-09-12 3:25 ` Sonny Rao
2014-09-12 11:43 ` Christopher Covington
2014-09-12 12:14 ` Marc Zyngier
[not found] ` <5412E3BB.9030800-5wv7dgnIgG8@public.gmane.org>
2014-09-12 18:59 ` Stephen Boyd
[not found] ` <54134291.3040700-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-09-15 11:10 ` Catalin Marinas
2014-09-15 20:33 ` Stephen Boyd
2014-09-15 21:47 ` Sonny Rao
2014-09-15 21:49 ` Stephen Boyd
2014-09-15 21:52 ` Sonny Rao
[not found] ` <CAPz6YkWbxiGHO8RK==HbQ3P22amZ9sDKpGew=a2U8gO7soQCDg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-15 22:04 ` Sonny Rao
2014-09-15 22:51 ` Christopher Covington
[not found] ` <54176D62.9010600-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-09-16 0:24 ` Sonny Rao
2014-09-16 10:42 ` Catalin Marinas
[not found] ` <20140916104242.GC27273-5wv7dgnIgG8@public.gmane.org>
2014-09-16 11:22 ` Christopher Covington
[not found] ` <54174CFF.7050504-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-09-16 11:03 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5411D528.4050605@arm.com \
--to=marc.zyngier@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=Mark.Rutland@arm.com \
--cc=Nathan_Lynch@mentor.com \
--cc=Pawel.Moll@arm.com \
--cc=Sudeep.Holla@arm.com \
--cc=cov@codeaurora.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=sonnyrao@chromium.org \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).