From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH] fbdev: fsl-sii902x: HDMI support for Freescale SoCs Date: Fri, 12 Sep 2014 12:34:17 +0300 Message-ID: <5412BE19.2010302@ti.com> References: <1409892517-29816-1-git-send-email-Li.Xiubo@freescale.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0ff6aQeaPd3M3s1MAo9HX6mg2ScwMT9ut" Return-path: In-Reply-To: <1409892517-29816-1-git-send-email-Li.Xiubo-KZfg59tc24xl57MIdRCFDg@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Xiubo Li Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org, grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, daniel.vetter-/w4YWyX8dFk@public.gmane.org, laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org, robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org --0ff6aQeaPd3M3s1MAo9HX6mg2ScwMT9ut Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Hi, On 05/09/14 07:48, Xiubo Li wrote: > Some Freescale SoCs, there has an DVI/HDMI controller and a PHY, > attached to one of their display controller unit's LCDC interfaces. > This patch adds a preliminary static support for such controllers. >=20 > This will support for many modes and a dynamic switching between > them. >=20 > Signed-off-by: Xiubo Li > --- > .../devicetree/bindings/video/fsl-sii902x.txt | 17 + > drivers/video/fbdev/Kconfig | 7 + > drivers/video/fbdev/Makefile | 1 + > drivers/video/fbdev/fsl-sii902x.c | 526 +++++++++++++= ++++++++ > 4 files changed, 551 insertions(+) > create mode 100644 Documentation/devicetree/bindings/video/fsl-sii902x= =2Etxt > create mode 100644 drivers/video/fbdev/fsl-sii902x.c I don't know how you picked the names of the people you sent this patch to, but looks to me that most of them are probably not interested in this patch. Anyway, a few quick comments on the patch: - You should probably use regmap instead of direct i2c calls. Interestingly, you define regmap variable, but you never use it. - Use defines for register offsets, instead of magic numbers. - You should not use static variables. They prevent having multiple instances of the device. So the SiI902x chip is on the SoC, not on the board? And it's a plain standard SiI902x in other aspects? Tomi --0ff6aQeaPd3M3s1MAo9HX6mg2ScwMT9ut Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUEr4ZAAoJEPo9qoy8lh71CpAQAKoDh2t5GoUuDQpPouk0PjlM u03FFs+tJDnol6nKjrA2aWdhi9tAUhofT2dyrnmlrHMPmhCRUZxuyuLFFVvYDcz9 OUpt7nk80zAAhHwwsr4gReSzhLP7sTfqVjvuD4fwvA2Iff8XJI1v8ZTpSznz30PV 77Nog6FoZpukkookxs1U2YEvftgHuox3DwKweyaTensWsbS17NJw7bjVLYehtqlQ RTFIz5kwhzbL6NEKY/FVTyEFxrqB3lck/r8bhbkRmEUunA9blJC/GVTiVYFTAW5d sJFfAS2Jo1yuKHtfpHjQoaCO/QcLV9I9MG1q7m+atXqy2SYW0nuxk0z79Gal4buu IENJXu+uh+lsbWNBeoS+KjPpVtCmX7+yFYXdsHg2LhS7KVY4z/Qjkd+a2hc1tyl1 iQktbfdRm/0MLsNlI/dPpH19prgPg9Q0rxJJJKLcx9VtCE/3iZZZOzVJSz4o3ESN G7wfKLD+U9UQbow0g/UBWCqL58POVxxZtt37oYcQZ81i41H76D7xTK5ZscKQ9XBi PguTkAs2LCa2p3NlQPvuGdsA4cZCiWHjo3yNlY4HGzrG9/nXzz1B/JdeuZf3rzxN OgJnKs2ak0MfajQudQOgC0UcvQ//CRwXQDcjf6VagzYUIH0f9Qj5cmO4mqMC238I 9sZSar3jJYIOgo9ICHi6 =phmy -----END PGP SIGNATURE----- --0ff6aQeaPd3M3s1MAo9HX6mg2ScwMT9ut-- -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html