From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hartmut Knaack Subject: Re: [PATCH v3 5/5] iio: add documentation for current attribute Date: Sun, 14 Sep 2014 15:13:48 +0200 Message-ID: <5415948C.6080509@gmx.de> References: <1410477357-6407-1-git-send-email-jacob.jun.pan@linux.intel.com> <1410477357-6407-6-git-send-email-jacob.jun.pan@linux.intel.com> <5414A138.9080602@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5414A138.9080602-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jonathan Cameron , Jacob Pan , IIO , LKML , DEVICE TREE , Lee Jones Cc: Carlo Caione , Srinivas Pandruvada , Aaron Lu , Alan Cox , Samuel Ortiz , Liam Girdwood , Mark Brown , Grant Likely , Greg Kroah-Hartman , Rob Herring , Lars-Peter Clausen , Fugang Duan , Arnd Bergmann , Zubair Lutfullah , Sebastian Reichel , Johannes Thumshirn , Philippe Reynes , Angelo Compagnucci , Doug Anderson , Ramakrishna Pallala , Peter Meerwald , Maxime Ripard List-Id: devicetree@vger.kernel.org Jonathan Cameron schrieb, Am 13.09.2014 21:55: > On 12/09/14 00:15, Jacob Pan wrote: >> Add documentation for input current raw reading and scale. >> >> Signed-off-by: Jacob Pan > The content is fine, but please look at how the other types are handled. > The raw attribute is described along with the units etc in it's own > section, but the _scale attribute just gets lumped in with the equivalent > for all the other channel types. > > Thanks, > > Jonathan >> --- >> Documentation/ABI/testing/sysfs-bus-iio | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio >> index d760b02..3c76bd8 100644 >> --- a/Documentation/ABI/testing/sysfs-bus-iio >> +++ b/Documentation/ABI/testing/sysfs-bus-iio >> @@ -1028,3 +1028,11 @@ Contact: linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> Description: >> Raw value of rotation from true/magnetic north measured with >> or without compensation from tilt sensors. >> + >> +What: /sys/bus/iio/devices/iio:deviceX/in_currentX_raw >> +What: /sys/bus/iio/devices/iio:deviceX/in_currentX_scale >> +KernelVersion: 3.18 >> +Contact: linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> +Description: >> + Raw current measurement from channel X. Units after application of >> + scale and offset are milliamps. Where is the offset? >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >