devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
To: Daniel Golle <daniel@makrotopia.org>,
	Aurelien Jarno <aurelien@aurel32.net>,
	Olivia Mackall <olivia@selenic.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	linux-crypto@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v2] dt-bindings: rng: rockchip,rk3588-rng: Drop unnecessary status from example
Date: Fri, 07 Mar 2025 15:05:50 +0100	[thread overview]
Message-ID: <5417098.31r3eYUQgx@workhorse> (raw)
In-Reply-To: <20250307093309.44950-1-krzysztof.kozlowski@linaro.org>

On Friday, 7 March 2025 10:33:09 Central European Standard Time Krzysztof 
Kozlowski wrote:
> Device nodes are enabled by default, so no need for 'status = "okay"' in
> the DTS example.
> 
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Changes in v2:
> 1. Drop unnecessary full stop in subject prefix after ':'.
> 2. Add Rb tag.
> ---
>  Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml
> b/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml index
> 757967212f55..ca71b400bcae 100644
> --- a/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml
> +++ b/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml
> @@ -53,7 +53,6 @@ examples:
>          interrupts = <GIC_SPI 400 IRQ_TYPE_LEVEL_HIGH 0>;
>          clocks = <&scmi_clk SCMI_HCLK_SECURE_NS>;
>          resets = <&scmi_reset SCMI_SRST_H_TRNG_NS>;
> -        status = "okay";
>        };
>      };

Hi,

is there the possibility we could make dtschema as invoked by `make 
dt_binding_check W=1` (or W=2) add a warning for examples that have disabled 
or explicitly listed status properties when not needed? Or is this something 
better handled in, say, checkpatch.pl?

The question arises because dumb mistakes by me like this should ideally be 
caught before they waste precious maintainer time.

If it's best handled in dtschema, I can look into working on that so you guys 
don't have to do even more work due to me.

Cheers,
Nicolas Frattaroli



  reply	other threads:[~2025-03-07 14:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-07  9:33 [PATCH v2] dt-bindings: rng: rockchip,rk3588-rng: Drop unnecessary status from example Krzysztof Kozlowski
2025-03-07 14:05 ` Nicolas Frattaroli [this message]
2025-03-10 12:49   ` Rob Herring
2025-03-10 19:30     ` Rob Herring
2025-03-10 12:50 ` Rob Herring (Arm)
2025-03-15  9:16 ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5417098.31r3eYUQgx@workhorse \
    --to=nicolas.frattaroli@collabora.com \
    --cc=aurelien@aurel32.net \
    --cc=conor+dt@kernel.org \
    --cc=daniel@makrotopia.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=olivia@selenic.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).