devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Josh Cartwright <joshc@codeaurora.org>,
	Kumar Gala <galak@codeaurora.org>
Cc: Pramod Gurav <pramod.gurav@smartplayin.com>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] ARM: DT: ifc6410: Add board memory range.
Date: Wed, 17 Sep 2014 22:49:39 +0100	[thread overview]
Message-ID: <541A01F3.4020303@linaro.org> (raw)
In-Reply-To: <20140917191829.GC3749@joshc.qualcomm.com>



On 17/09/14 20:18, Josh Cartwright wrote:
> On Wed, Sep 17, 2014 at 12:03:37PM -0700, Kumar Gala wrote:
>> On Sep 16, 2014, at 11:34 PM, Pramod Gurav <pramod.gurav@smartplayin.com> wrote:
>>> On Wednesday 17 September 2014 11:06 AM, Srinivas Kandagatla wrote:
>>>> This patch adds memory details of IFC6410 as this is necessary to
>>>> fix the in-correct memory start comming from ATAGs.
>>>>
>>>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>>>> ---
>>>> arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 5 +++++
>>>> 1 file changed, 5 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
>>>> index 90db8af..3287f12 100644
>>>> --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
>>>> +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
>>>> @@ -4,6 +4,11 @@
>>>> 	model = "Qualcomm APQ8064/IFC6410";
>>>> 	compatible = "qcom,apq8064-ifc6410", "qcom,apq8064";
>>>>
>>>> +	memory{
>>> Space before {?
>>>> +		device_type = "memory";
>>>> +		reg = <0x80000000 0x80000000>;
>>>> +	};
>>>> +
>>>> 	soc {
>>>> 		gsbi@16600000 {
>>>> 			status = "ok?;
>>
>> Hmm, this doesn?t seem to work for me.
>
> I don't see how it could with qcom_defconfig, as we set
> CONFIG_ARM_ATAG_DTB_COMPAT.  Is this patch fixing a real issue?
No, its not fixing any thing by itself.

However along with "ARM: zImage: Allow DTB to override broken ATAG_MEM" 
patch atleast I get to boot my IFC6410 with multi_v7_defconfig.

>

  reply	other threads:[~2014-09-17 21:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-17  5:36 [PATCH] ARM: DT: ifc6410: Add board memory range Srinivas Kandagatla
2014-09-17  6:34 ` Pramod Gurav
2014-09-17 19:03   ` Kumar Gala
2014-09-17 19:18     ` Josh Cartwright
2014-09-17 21:49       ` Srinivas Kandagatla [this message]
2014-09-18  4:37         ` Bjorn Andersson
2014-09-18 14:16           ` Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=541A01F3.4020303@linaro.org \
    --to=srinivas.kandagatla@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=joshc@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=pramod.gurav@smartplayin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).