Re: [PATCH v3 1/2] bcma: register bcma as device tree driver

[Varka Bhadram <varkabhadram-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

On Saturday 20 September 2014 09:13 PM, Hauke Mehrtens wrote:
> On 09/20/2014 05:40 PM, Varka Bhadram wrote:
>> On Saturday 20 September 2014 06:32 PM, Hauke Mehrtens wrote:
>>> This driver is used by the bcm53xx ARM SoC code. Now it is possible to
>>> give the address of the chipcommon core in device tree and bcma will
>>> search for all the other cores.
>> (...)
>>
>>> +
>>> +static const struct of_device_id bcma_host_soc_of_match[] = {
>>> +    { .compatible = "brcm,bus-axi", },
>>> +    {},
>>> +};
>>> +MODULE_DEVICE_TABLE(of, bcma_host_soc_of_match);
>>> +
>>> +static struct platform_driver bcma_host_soc_driver = {
>>> +    .driver = {
>>> +        .name = "bcma-host-soc",
>>> +        .owner = THIS_MODULE,
>> This field updated automatically...
> Ok, I will remove this line.
>
>>> +        .of_match_table = bcma_host_soc_of_match,
>>> +    },
>>> +    .probe        = bcma_host_soc_probe,
>>> +    .remove        = bcma_host_soc_remove,
>>> +};
>>> +
>>> +int __init bcma_host_soc_register_driver(void)
>>> +{
>>> +    return platform_driver_register(&bcma_host_soc_driver);
>>> +}
>>> +
>>> +void __exit bcma_host_soc_unregister_driver(void)
>>> +{
>>> +    platform_driver_unregister(&bcma_host_soc_driver);
>>> +}
>>> +#endif /* CONFIG_OF */
>> Why dont you use module_platform_driver(...)...?
> module_platform_driver() does not work, because we can only have one
> module_init() method in a module and main.c already has one. This driver
> can also be registered as an PCI device.

Ok.. thanks


-- 
-Varka Bhadram

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html