From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@free-electrons.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/5] ARM: mvebu: armada-xp: Correct misnumbered PCIe port nodes
Date: Sun, 21 Sep 2014 01:46:03 +0200 [thread overview]
Message-ID: <541E11BB.7070202@gmail.com> (raw)
In-Reply-To: <1411236391-422-4-git-send-email-sebastian.hesselbarth@gmail.com>
On 09/20/2014 08:06 PM, Sebastian Hesselbarth wrote:
> Currently, Armada XP PCIe nodes are numbered pcie@<N>,0 with N just
> incrementing. To reflect port/lane relationship, rename the nodes
> to pcie@<port>,<lane>. While at it, add node aliases to each of pcie
> controller and port nodes and get rid of now redundant port/lane
> comments.
>
> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> ---
After thinking a while about the current numbering scheme, I have to
admit that it is correct. The @numbers represent assigned-address of
the pcie port and this what it is right now.
If there are no more comments, I'll resend the series without messing
with the numbering scheme.
Sebastian
> ---
> arch/arm/boot/dts/armada-xp-axpwifiap.dts | 11 ++++-------
> arch/arm/boot/dts/armada-xp-db.dts | 20 +++++++-------------
> arch/arm/boot/dts/armada-xp-gp.dts | 11 ++++-------
> arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts | 8 +++-----
> arch/arm/boot/dts/armada-xp-matrix.dts | 5 ++---
> arch/arm/boot/dts/armada-xp-mv78230.dtsi | 12 ++++++------
> arch/arm/boot/dts/armada-xp-mv78260.dtsi | 20 ++++++++++----------
> arch/arm/boot/dts/armada-xp-mv78460.dtsi | 22 +++++++++++-----------
> arch/arm/boot/dts/armada-xp-netgear-rn2120.dts | 11 ++++-------
> arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts | 5 ++---
> 10 files changed, 53 insertions(+), 72 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-xp-axpwifiap.dts b/arch/arm/boot/dts/armada-xp-axpwifiap.dts
> index 0e53fad111de..1b2dd3a4000b 100644
> --- a/arch/arm/boot/dts/armada-xp-axpwifiap.dts
> +++ b/arch/arm/boot/dts/armada-xp-axpwifiap.dts
> @@ -37,24 +37,21 @@
> ranges = <MBUS_ID(0xf0, 0x01) 0 0 0xf1000000 0x100000
> MBUS_ID(0x01, 0x1d) 0 0 0xfff00000 0x100000>;
>
> - pcie-controller {
> + pcie: pcie-controller {
> status = "okay";
>
> /* First mini-PCIe port */
> - pcie@1,0 {
> - /* Port 0, Lane 0 */
> + pcie00: pcie@0,0 {
> status = "okay";
> };
>
> /* Second mini-PCIe port */
> - pcie@2,0 {
> - /* Port 0, Lane 1 */
> + pcie01: pcie@0,1 {
> status = "okay";
> };
>
> /* Renesas uPD720202 USB 3.0 controller */
> - pcie@3,0 {
> - /* Port 0, Lane 3 */
> + pcie03: pcie@0,3 {
> status = "okay";
> };
> };
[...]
next prev parent reply other threads:[~2014-09-20 23:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1411236391-422-1-git-send-email-sebastian.hesselbarth@gmail.com>
2014-09-20 18:06 ` [PATCH 1/5] PCI: mvebu: Amend PCIe controler node documentation Sebastian Hesselbarth
[not found] ` <1411236391-422-1-git-send-email-sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-09-20 18:06 ` [PATCH 2/5] PCI: mvebu: Count number of lanes Sebastian Hesselbarth
2014-09-20 18:06 ` [PATCH 3/5] ARM: mvebu: armada-xp: Correct misnumbered PCIe port nodes Sebastian Hesselbarth
2014-09-20 23:46 ` Sebastian Hesselbarth [this message]
2014-09-22 22:12 ` Bjorn Helgaas
2014-09-20 18:06 ` [PATCH 4/5] ARM: mvebu: armada-xp: Use PCIe node aliases Sebastian Hesselbarth
2014-09-20 18:06 ` [PATCH 5/5] ARM: mvebu: armada-xp: Configure ix4-300d PCIe0 to x4 Sebastian Hesselbarth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541E11BB.7070202@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=andrew@lunn.ch \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregory.clement@free-electrons.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).