From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Zhong Subject: Re: [PATCH v4 1/2] regulator: st-pwm: get voltage and duty table from dts Date: Mon, 22 Sep 2014 12:47:30 +0800 Message-ID: <541FA9E2.60604@rock-chips.com> References: <1411354380-14326-1-git-send-email-zyw@rock-chips.com> <1411354380-14326-2-git-send-email-zyw@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Doug Anderson Cc: =?UTF-8?B?SGVpa28gU3TDvGJuZXI=?= , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Lee Jones , "broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , Liam Girdwood , Grant Likely , Rob Herring , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On 09/22/2014 12:18 PM, Doug Anderson wrote: > Chris, > > On Sun, Sep 21, 2014 at 7:52 PM, Chris Zhong wrote: >> Get voltage & duty table from device tree might be better, other platforms can also use this >> driver without any modify. >> >> Signed-off-by: Chris Zhong >> >> Reviewed-by: Doug Anderson > No need to re-spin, but please remember that all tags should be > bunched together (no blank lines). In other words, > > YES: > >> Signed-off-by: Chris Zhong >> Reviewed-by: Doug Anderson > NO: > >> Signed-off-by: Chris Zhong >> >> Reviewed-by: Doug Anderson Thanks. It seems the patman add the blank line, I will manually modify it next time. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html