From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mao Jinlong <quic_jinlmao@quicinc.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Tingwei Zhang <quic_tingweiz@quicinc.com>,
Yuanfang Zhang <quic_yuanfang@quicinc.com>,
Tao Zhang <quic_taozha@quicinc.com>
Subject: Re: [PATCH v3 1/4] dt-bindings: arm: Add remote etm dt-binding
Date: Thu, 7 Dec 2023 10:39:19 +0100 [thread overview]
Message-ID: <541f9ecb-b0d1-4c30-ae02-87376436cda3@linaro.org> (raw)
In-Reply-To: <20231206141502.27016-2-quic_jinlmao@quicinc.com>
On 06/12/2023 15:14, Mao Jinlong wrote:
> Remote ETM(Embedded Trace Macrocell) is to capture information of
> the executed processor instructions of remote processors like modem.
> Add new coresight-remote-etm.yaml file describing the bindings
> required to define coresight remote etm in the device trees.
>
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + etm {
> + compatible = "qcom,coresight-remote-etm";
Now something happened with your indentation here... was it like this
before? The guideline asks to use 2 or 4 space indentation for the
example, while 4 is preferred.
With fixed indentation in the example:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-07 9:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 14:14 [PATCH v3 0/4] arm64: dts: qcom: Fix the warnings from coresight bindings Mao Jinlong
2023-12-06 14:14 ` [PATCH v3 1/4] dt-bindings: arm: Add remote etm dt-binding Mao Jinlong
2023-12-07 9:39 ` Krzysztof Kozlowski [this message]
2023-12-06 14:14 ` [PATCH v3 2/4] arm64: dts: qcom: msm8996: Fix 'in-ports' is a required property Mao Jinlong
2023-12-07 9:39 ` Krzysztof Kozlowski
2023-12-06 14:14 ` [PATCH v3 3/4] arm64: dts: qcom: msm8998: Fix 'out-ports' " Mao Jinlong
2023-12-06 14:14 ` [PATCH v3 4/4] arm64: dts: qcom: Fix coresight warnings in in-ports and out-ports Mao Jinlong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541f9ecb-b0d1-4c30-ae02-87376436cda3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_jinlmao@quicinc.com \
--cc=quic_taozha@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_yuanfang@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).