From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1EC42FA0F0 for ; Sat, 20 Sep 2025 15:05:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758380744; cv=none; b=fDKZkraQBOe1dm9LU0Y8sr37nYsx03m/AbLlBQovVxoxDm3eTOq5rwQq/Gt+mKObqbuDe8FxH10i4mtK+4IRQ5RJ1wLCE88Cu2iy8WAaHxUsbeyQoXeuaxXLWjFyq+VaGHmxnMdoN7PquoTo56wYCBJFdzXKsCDci48c1UBodKE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758380744; c=relaxed/simple; bh=aWayvqL3VDfszikMhDxl8W1TgKxHXMgXHh6mTuD+Pk0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iRKHCAQWqviC7Dwou6IjXFOgYq/ctU/G6MxdZn70NVhioMaLxP0keS3ivR+JT5GF2fpo7Ev8dwrpfOV4aFJcRH883VXnsViWvZB3Vnz/a2xlaWlZM4Tu8DFbfOdHSMcnhLUOuYy3ioldIiwD9/CKHOd/j9hS3hPEbTwekCsXbkY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=f7btD9Bc; arc=none smtp.client-ip=209.85.210.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="f7btD9Bc" Received: by mail-ot1-f53.google.com with SMTP id 46e09a7af769-74381df387fso1599050a34.0 for ; Sat, 20 Sep 2025 08:05:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1758380742; x=1758985542; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ApPm9TrFpXMEdiMfo67L+FcuF5N4ixQDCyPBv1VUDxI=; b=f7btD9Bc/p2IJpCz3JU4pDTlcwTXA7+lb+iE9Jxu+DjwQ0efBA+DFNsfR8R2261ePi 5K+cmGUsn4emmz7hNbr6PLGTSzeXkbNKe25Bi77VaYBhVd+DKcPoa3jjMCO6o05ayQye iPEu83EYVxRr1gzVAxZxPmTF6WN3ieWQvuVYpQXH5HFYa89W6WUp8Ud/E3GeOTLUNInS DAOLfPJbMqMXHsR6owyToe8TjWcOEPl2+SMWnzzEWuXqZoPtCU5RgKy39AmLDrcVroZR QzXaaJfyZgJZNuJVXkXRCLMpsMZ/fuWhDYCvcECjhnBa0rig0Eh1zC9dh795vxHXr8q5 gnzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758380742; x=1758985542; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ApPm9TrFpXMEdiMfo67L+FcuF5N4ixQDCyPBv1VUDxI=; b=NXzL4vC6RoJx3U3iYrZg3gjkTbDtw8ecbqp5YJr1VFtpxjnaeFMAu2VZj1OLce+C3b Pww6PGg2nDfyH/yqSH80ZdpY8ICljqygCkUw0IGi2EFhnvf18tlY/74iwyiCigfqK9Os pZIXEdniq8ljO8UqNH7rGQcEZ43IKpe+HkaOTD2Wl0uQX5hHNmOF5EklOGPh+cBnNbtP UX+p0d9G4p77i5+2EKq3SyoaIAlxl0CNe1cB83f+NWl0pSKAWVHOom30Z1Z00pv1qJ7e i1GzNBPho7JXlM92Upea8pLrHvmlDQxAW5rTGarB4HbGxTWrPYxHdjkUJJeS3W78pJMF mPHQ== X-Forwarded-Encrypted: i=1; AJvYcCULrtZyzYEYJX9TZwu3CaWIXU9h+dMjHPcte9VRHMo9fYUI8df398fSORjDs2wbMY5cTxJPk4gfHjB7@vger.kernel.org X-Gm-Message-State: AOJu0Yx6yya+yg4cmbjV1uIg4F1lztvgMwfmCU480Yhipxz5opFLIbon hutV/EUlhwUIe8fz42utGpHx/BXLnjSIyVoPcGEC+lZFfJT+IDZGtKC2B4jox0o0K8U= X-Gm-Gg: ASbGncvk7q2NS9Sd4vjw38f3jhLwkr0BoiuXXJdMrLkbX668W1sfwVn+r/Yuugi3soh BFtOjLKH6v182TTiat+fEPpi9MOKBI1jbPFLYDHcGeo69RYWxsDjsg2GzUFkrDcGufktu5T99/c 618okkcvaH79zn4fbt93qrjmfYKwcikpxdZuOSRecFyAeTSoKcl7EL+lxn4eIciejfKXnPqtQVJ QPYjeW21UF8kQ2l8iU7OLBTrjCp04nWqbiix2LX5bNyJMQHwIo/o5ysguJbnLNV5MJXN3UdpWnA 36h+8hHckhtgmTqdz8QO1Ibg5v4UgU7DhF3fXYBlJCFWYbQK4+3Wq3Lia+wdjbwNCW6F1Pfbxqc 8rPZ2w6idBQHc5OT5D6ieI2iXN1JznVWzZHMhN3hMMbveqsAchjSi69j5x6sabHS9/EOHaRiebO E= X-Google-Smtp-Source: AGHT+IF5DOCsFnmXWBk4EFUMe3TaSuHUTrmx8iC4wB7mmSr96ueHoL1IQtk8a+YwSVn8HW8dh3oXUA== X-Received: by 2002:a05:6830:6687:b0:758:9be6:b5b9 with SMTP id 46e09a7af769-76f81bbd71emr3753044a34.32.1758380741945; Sat, 20 Sep 2025 08:05:41 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:1d00:14ea:b68a:f92c:93c4? ([2600:8803:e7e4:1d00:14ea:b68a:f92c:93c4]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-625d5d22e21sm2630056eaf.0.2025.09.20.08.05.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 20 Sep 2025 08:05:40 -0700 (PDT) Message-ID: <5420e895-fcd4-4632-81d3-389c6439afde@baylibre.com> Date: Sat, 20 Sep 2025 10:05:40 -0500 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] iio: temperature: add support for EMC1812 To: Jonathan Cameron , Marius Cristea Cc: =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250917-iio-emc1812-v1-0-0b1f74cea7ab@microchip.com> <20250917-iio-emc1812-v1-2-0b1f74cea7ab@microchip.com> <20250920125144.41f70a1f@jic23-huawei> Content-Language: en-US From: David Lechner In-Reply-To: <20250920125144.41f70a1f@jic23-huawei> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/20/25 6:51 AM, Jonathan Cameron wrote: > On Wed, 17 Sep 2025 15:21:58 +0300 > Marius Cristea wrote: > ... >> + if (ret) >> + return ret; >> + >> + ret = regmap_write(priv->regmap, EMC1812_CONSEC_ALERT_ADDR, 0x70); >> + if (ret) >> + return ret; >> + >> + ret = regmap_write(priv->regmap, EMC1812_FILTER_SEL_ADDR, 0); >> + if (ret) >> + return ret; >> + >> + ret = regmap_write(priv->regmap, EMC1812_HOTTEST_CFG_ADDR, 0); >> + if (ret) >> + return ret; >> + >> + /* Set beta1 and beta2 compensation parameters */ >> + for (i = 0; i < ARRAY_SIZE(priv->beta_values); i++) { >> + ret = regmap_write(priv->regmap, EMC1812_BETA_CFG_ADDR(i), >> + priv->beta_values[i]); >> + if (ret) >> + return ret; >> + } >> + >> + /* Set ideality factor for all external channels */ >> + ret = regmap_write(priv->regmap, EMC1812_EXT1_IDEALITY_FACTOR_ADDR, > > Perhaps a look up table for the registers and a loop? > > Also see regmap_multi_reg_write() and regmap_register_patch().