From: Tomasz Figa <tomasz.figa@gmail.com>
To: Abhilash Kesavan <a.kesavan@samsung.com>,
linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org, catalin.marinas@arm.com,
robh@kernel.org, devicetree@vger.kernel.org,
linus.walleij@linaro.org
Subject: Re: [PATCH v3 3/6] pinctrl: exynos: Add irq_chip instance for Exynos7 wakeup interrupts
Date: Tue, 30 Sep 2014 00:46:03 +0200 [thread overview]
Message-ID: <5429E12B.5020708@gmail.com> (raw)
In-Reply-To: <1411967712-8321-4-git-send-email-a.kesavan@samsung.com>
Hi Abhilash,
Just two minor issues inline. I leave them up to Linus to decide.
Linus, if you don't mind them, feel free to apply this patch with my Ack.
On 29.09.2014 07:15, Abhilash Kesavan wrote:
> Exynos7 uses different offsets for wakeup interrupt configuration registers.
> So a new irq_chip instance for Exynos7 wakeup interrupts is added. The irq_chip
> selection is now based on the wakeup interrupt controller compatible string.
[snip]
> @@ -469,12 +488,18 @@ static int exynos_eint_wkup_init(struct samsung_pinctrl_drv_data *d)
> struct samsung_pin_bank *bank;
> struct exynos_weint_data *weint_data;
> struct exynos_muxed_weint_data *muxed_data;
> + struct exynos_irq_chip *exynos_wkup_irq_chip;
Quite an awful name for a local variable. "irq_chip" alone would be enough.
> unsigned int muxed_banks = 0;
> unsigned int i;
> int idx, irq;
>
> for_each_child_of_node(dev->of_node, np) {
> - if (of_match_node(exynos_wkup_irq_ids, np)) {
> + const struct of_device_id *match;
> +
> + match = of_match_node(exynos_wkup_irq_ids, np);
> + if (match) {
> + exynos_wkup_irq_chip = kmemdup(match->data,
> + sizeof(struct exynos_irq_chip), GFP_KERNEL);
sizeof(*exynos_wkup_irq_chip) (or irq_chip considering my comment above)
could be used instead.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-09-29 22:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 5:15 [PATCH v3 0/6] Add initial support for pinctrl on Exynos7 Abhilash Kesavan
2014-09-29 5:15 ` [PATCH v3 1/6] pinctrl: exynos: Generalize the eint16_31 demux code Abhilash Kesavan
2014-09-29 5:15 ` [PATCH v3 2/6] pinctrl: exynos: Consolidate irq domain callbacks Abhilash Kesavan
2014-09-29 5:15 ` [PATCH v3 3/6] pinctrl: exynos: Add irq_chip instance for Exynos7 wakeup interrupts Abhilash Kesavan
2014-09-29 22:46 ` Tomasz Figa [this message]
2014-09-30 14:26 ` Abhilash Kesavan
2014-09-29 5:15 ` [PATCH v3 4/6] pinctrl: exynos: Add initial driver data for Exynos7 Abhilash Kesavan
2014-09-29 5:15 ` [PATCH v3 5/6] arm64: dts: Add initial pinctrl support to EXYNOS7 Abhilash Kesavan
2014-09-29 5:15 ` [PATCH v3 6/6] arm64: exynos: Enable pinctrl support for Exynos7 Abhilash Kesavan
2014-09-29 22:49 ` [PATCH v3 0/6] Add initial support for pinctrl on Exynos7 Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5429E12B.5020708@gmail.com \
--to=tomasz.figa@gmail.com \
--cc=a.kesavan@samsung.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).